Issue metadata
Sign in to add a comment
|
Ink drop showing up when a tooltip appears on a ShelfButton. |
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3557.0 What steps will reproduce the problem? (1) Show tooltip over a ShelfButton (app icon). What is the expected result? No ink drop. What happens instead? Ink drop appears.
,
Sep 25
WAI?
,
Sep 25
not WAI. ripple and active states should only be displayed upon click or tap. Not hover.
,
Sep 25
,
Sep 25
TY sir, I'll unassign so someone from our team knows it is available.
,
Oct 15
Bulk moving all M-71 <P-1's to M-72.
,
Oct 15
,
Oct 26
,
Oct 27
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 19
,
Dec 19
Err, oops, please disregard #12, I updated the wrong bug.
,
Dec 19
FYI sent out fix as CL 1382670
,
Dec 19
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8cf9fc401ba4db762c7914f7e3874952ba73993 commit c8cf9fc401ba4db762c7914f7e3874952ba73993 Author: Manu Cornet <manucornet@chromium.org> Date: Thu Dec 20 09:51:16 2018 CrOS shelf: do not highlight shelf items on hover When we show a bubble anchored to a certain view, it's usually the case that we also want to highlight that view to show what the bubble is attached to. However, in the case of shelf items, we show a bubble on hover, and highlighting the shelf item gives the impression that a tap/click event has occurred (see linked bug). This CL adds a flag to the bubble class to allow callers to disable the highlighting behavior. Bug: 888570 Change-Id: Id90bcf710cdc33263fcdd8d932a35b964d48fc9c Reviewed-on: https://chromium-review.googlesource.com/c/1382670 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#618153} [modify] https://crrev.com/c8cf9fc401ba4db762c7914f7e3874952ba73993/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/c8cf9fc401ba4db762c7914f7e3874952ba73993/ui/views/bubble/bubble_dialog_delegate_view.cc [modify] https://crrev.com/c8cf9fc401ba4db762c7914f7e3874952ba73993/ui/views/bubble/bubble_dialog_delegate_view.h
,
Dec 20
This has been going on for a while and is probably not severe enough to warrant a cherrypick. Let me know if you feel strongly. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Sep 24