Issue metadata
Sign in to add a comment
|
4.4%-1044.4% regression in rasterize_and_record_micro.top_25 at 593208:593441 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 24
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/163f4a57640000
,
Sep 24
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/163f4a57640000 Use vpython and remove vendored pymock. by jbudorick@chromium.org https://chromium.googlesource.com/catapult/+/23c67a511280f6dbc2a2bea849dd7eed5104809e 51.14 → No values Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
,
Sep 25
CL in question was reverted.
,
Oct 5
jbudorick: This issue has not recovered. Please don't just close alert issues with large regressions without checking that they recovered. chrishtr: Was there anything Paint related in this range that could have changed raster times? It looks like paint op counts changed, and some page raster times are significantly up.
,
Oct 5
I think the most likely is this: https://chromium.googlesource.com/chromium/src/+/de46e4da83ac65a2f1979935460ed05ef8a1a04d (re-enable zoom for dsf) Also correlates with all regressions being on Android.
,
Oct 5
Ahh, since normal raster thread times didn't regress, does it mean the rasterize_and_record benchmark code may be missing the scale factor?
,
Oct 5
I don't think it should be missed, because zoom for dsf hides the device scale factor in Blink instead of doing it in cc.
,
Oct 5
Thee rasterize_time tests doesn't have zoom factor applied. This is same as issue 871372 . I have confirmed with vmpstr@ that this is expected. the nested-percent-height-tables regression is due to table element doesn't have sup-pixel support yet. (issue 871387) I checked with eae@ and dgrogan@, and we agree this issue can be ignore for now.
,
Oct 5
> Thee rasterize_time tests doesn't have zoom factor applied. This is same as > issue 871372 . I have confirmed with vmpstr@ that this is expected. Wait, shouldn't we apply it? Why WontFix?
,
Oct 6
The test passes gfx::AxisTransform2d()[1], which means hard coded device scale factor to be 1.f. This is different from real world, so the increment is expected. I'm not sure if there is plan to change this. If there is a plan, I think someone from GPU team would be more appropriate than me. [1] https://cs.chromium.org/chromium/src/cc/benchmarks/rasterize_and_record_benchmark_impl.cc?type=cs&q=RasterizeAndRecordBenchmarkImpl::RunOnLayer&g=0&l=199 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 24