New issue
Advanced search Search tips

Issue 888545 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 892211



Sign in to add a comment

Add Logging to Open-In feature

Project Member Reported by mrefaat@chromium.org, Sep 24

Issue description

That feature is the main user of the new WKHTTPSystemCookieStore.
logging will help measure the performance.
 
Components: Mobile>WebView>Glue
Components: -Mobile>WebView>Glue UI>Browser>Core
Any update here? Stable cut is next week.
Labels: -M-70 M-71
Change to Block M71 instead, as per conversation with eugenebut@ we can keep 1% of users in the old cookiestore.
Cc: linds...@chromium.org pkl@chromium.org
Lindsay, we want to measure the success of Cookie Store feature. But we don't have time to add relevant metrics to M70. Would you be ok if we run 1% experiment with old cookie store in M71 (after actually launching the feature)?
Blockedon: 892211
Also logging open in requires fixing it's failure detection. check  crbug.com/892211 

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d469a9b6d664d7581e122329cc70fd1ed56c53f6

commit d469a9b6d664d7581e122329cc70fd1ed56c53f6
Author: mrefaat <mrefaat@chromium.org>
Date: Fri Oct 05 21:59:17 2018

Add logging to OpenIn feature.

Detect download failure when a corrupted PDF was downloaded and log the
OpenIn download result in all cases.

Bug:  888545 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I19eefd9c1b6da0c9d6b18bfcc0f3953fb33ef391
Reviewed-on: https://chromium-review.googlesource.com/c/1259295
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597328}
[modify] https://crrev.com/d469a9b6d664d7581e122329cc70fd1ed56c53f6/ios/chrome/browser/ui/open_in_controller.h
[modify] https://crrev.com/d469a9b6d664d7581e122329cc70fd1ed56c53f6/ios/chrome/browser/ui/open_in_controller.mm
[modify] https://crrev.com/d469a9b6d664d7581e122329cc70fd1ed56c53f6/ios/chrome/browser/ui/open_in_controller_unittest.mm
[modify] https://crrev.com/d469a9b6d664d7581e122329cc70fd1ed56c53f6/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/d469a9b6d664d7581e122329cc70fd1ed56c53f6/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Branch was on Oct 11 - CL was sent on OCT 5 so it's on the branch already.

Sign in to add a comment