Issue metadata
Sign in to add a comment
|
Distorted web page after updating web browser (display: -webkit-box misbehaves)
Reported by
alejomar...@gmail.com,
Sep 24
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36 Steps to reproduce the problem: 1. In your web browser go to https://www.gba.gob.ar/provinciaabierta/presupuestoabierto What is the expected behavior? The web page is expected to load according to how it is displayed in the "Correct page" file. What went wrong? Since Chrome was upgraded to version 69, the indicated web page is "visually broken". Since previous versions of this browser and from other browsers, this bug does not occur, it only happens in this version of Chrome. Did this work before? Yes 68 Does this work in other browsers? Yes Chrome version: 69.0.3497.100 Channel: stable OS Version: Ubuntu 18.04 Flash Version: The indicated web page is a single screen and, as far as I understand, it is entirely developed with the Laravel framework. Could it be that there is some incompatibility in the 69 version of the browser with this framework and/or other technologies?
,
Sep 24
This website uses an old, deprecated and non-standard value for the display CSS property - -webkit-box. It, surprisingly, comes from Bootstrap 4.0.0. I have my doubts, though, because I do not believe Bootstrap would insist on using such an old value. The original Bootstrap 4.0.0 https://stackpath.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.css has display: flex (search for ".row"). Work around - .row { display:-webkit-box; ... } should also have display: flex (last). The issue is resolved with this workaround. Bisection led to - https://chromium.googlesource.com/chromium/src/+/ec1096b3e38911886aac84e97319d97cd445fb80 (Or https://chromium.googlesource.com/chromium/src/+/b4c748848d218484b60eb68cbe7d70dae4e6859c but this is just a trivial recipe change) Still reproduces in Chrome 71.0.3554.0 dev.
,
Sep 24
Unfortunately I cannot give you much information regarding the web system in question. I find it very difficult to read its code. It is very poorly developed. I have been guided by your comments and changing the property "display" to "flex" for the classes "row" I have solved the visual problem that affected me. I pray someday to be able to make this system from scratch, but for now, I can only patch these bugs. Thank you very much.
,
Sep 24
#4 - Bootstrap 4.0.0 is pretty new (January, 2018), so this a fairly recent addition/change, just so you know. Looks like someone messed with the code of Bootstrap itself (something that is usually not done). If it helps.
,
Sep 24
I work in a government office and for obvious reasons of confidentiality I cannot give you the source code of the system, but I can assure you that it is a horror. Imagine that there are indications that the code was originally designed for another system (a kind of blog or social network) and "adapted" it to make this system. Unbelievable that something like this happens and is used. Based on that, I have no doubt that someone has "put their hand" where it shouldn't and without any knowledge.
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22fb320e982b11fa75e4fe162a5261c56715d873 commit 22fb320e982b11fa75e4fe162a5261c56715d873 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Sep 24 22:32:31 2018 [PE] Fix paint offset of floating object under display:-webkit-box The IsLayoutBlock() condition is now consistent with the floating object locationing logic (which is based on its containing block), and the condition covers display:-webkit-box. No new test for the deprecated feature -webkit-box. Bug: 888534 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iafb4fe1f61b007209f7be8963686996b5a50dbf7 Reviewed-on: https://chromium-review.googlesource.com/1240742 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593718} [add] https://crrev.com/22fb320e982b11fa75e4fe162a5261c56715d873/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box-expected.html [add] https://crrev.com/22fb320e982b11fa75e4fe162a5261c56715d873/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box.html [modify] https://crrev.com/22fb320e982b11fa75e4fe162a5261c56715d873/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
,
Sep 25
Removing needs-bisect label as bisect is already provided in C#2. This would need merge to M-70 and to M-69(in case of stable respin) once the fix is verified on canary. Adding RB-Stable for tracking.
,
Sep 25
Issue 881725 has been merged into this issue.
,
Sep 25
Verified on Canary 71.0.3561.0. Requesting to merge into M70 which is safe. Removing M69 target because the bug is about a deprecated feature and has easy workaround.
,
Sep 25
#10 - I might have used too strong of a word there, I am not sure it is officially deprecated (there are no deprecation warnings). It is non-standard and old, that is accurate. Since it is old, I imagine websites that use it are not going to be updated with the workaround in a timely manner, so a 69 re-spin (in case it happens anyway) might be a good candidate for this. (Unless you think it is not a safe merge)
,
Sep 25
Agreed to merge into M69 because it's safe. Note that the bug affects only floating descendants of a -webkit-box container.
,
Sep 25
,
Sep 25
Let's merge this to M70. I don't think we're planning another respin for M69, so lets get this in beta first.
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa commit abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Sep 25 18:07:07 2018 [PE] Fix paint offset of floating object under display:-webkit-box The IsLayoutBlock() condition is now consistent with the floating object locationing logic (which is based on its containing block), and the condition covers display:-webkit-box. TBR=wangxianzhu@chromium.org (cherry picked from commit 22fb320e982b11fa75e4fe162a5261c56715d873) Bug: 888534 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iafb4fe1f61b007209f7be8963686996b5a50dbf7 Reviewed-on: https://chromium-review.googlesource.com/1240742 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593718} Reviewed-on: https://chromium-review.googlesource.com/1243808 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#966} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [add] https://crrev.com/abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box-expected.html [add] https://crrev.com/abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box.html [modify] https://crrev.com/abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
,
Sep 25
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa was merged to refs/branch-heads/3497 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa Commit: abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa Author: wangxianzhu@chromium.org Commiter: wangxianzhu@chromium.org Date: 2018-09-25 18:07:07 +0000 UTC [PE] Fix paint offset of floating object under display:-webkit-box The IsLayoutBlock() condition is now consistent with the floating object locationing logic (which is based on its containing block), and the condition covers display:-webkit-box. TBR=wangxianzhu@chromium.org (cherry picked from commit 22fb320e982b11fa75e4fe162a5261c56715d873) Bug: 888534 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iafb4fe1f61b007209f7be8963686996b5a50dbf7 Reviewed-on: https://chromium-review.googlesource.com/1240742 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593718} Reviewed-on: https://chromium-review.googlesource.com/1243808 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#966} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
,
Sep 25
Sorry I made a mistake about the branch number. Will revert in M69.
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/921eeecf4805b95e1224327dc54246e85f4c2930 commit 921eeecf4805b95e1224327dc54246e85f4c2930 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Sep 25 18:12:16 2018 Revert "[PE] Fix paint offset of floating object under display:-webkit-box" This reverts commit abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa. Reason for revert: Merged into the wrong branch. Original change's description: > [PE] Fix paint offset of floating object under display:-webkit-box > > The IsLayoutBlock() condition is now consistent with the floating object > locationing logic (which is based on its containing block), and the > condition covers display:-webkit-box. > > TBR=wangxianzhu@chromium.org > > (cherry picked from commit 22fb320e982b11fa75e4fe162a5261c56715d873) > > Bug: 888534 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iafb4fe1f61b007209f7be8963686996b5a50dbf7 > Reviewed-on: https://chromium-review.googlesource.com/1240742 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#593718} > Reviewed-on: https://chromium-review.googlesource.com/1243808 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/branch-heads/3497@{#966} > Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: Ic0d6bb0b46ba3550b07418bda0dbbbb35a06e347 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888534 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1243676 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#967} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [delete] https://crrev.com/abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box-expected.html [delete] https://crrev.com/abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box.html [modify] https://crrev.com/921eeecf4805b95e1224327dc54246e85f4c2930/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/921eeecf4805b95e1224327dc54246e85f4c2930 Commit: 921eeecf4805b95e1224327dc54246e85f4c2930 Author: wangxianzhu@chromium.org Commiter: wangxianzhu@chromium.org Date: 2018-09-25 18:12:16 +0000 UTC Revert "[PE] Fix paint offset of floating object under display:-webkit-box" This reverts commit abf64e2ea1757535ff6a97012d1a4ee95a5ce5fa. Reason for revert: Merged into the wrong branch. Original change's description: > [PE] Fix paint offset of floating object under display:-webkit-box > > The IsLayoutBlock() condition is now consistent with the floating object > locationing logic (which is based on its containing block), and the > condition covers display:-webkit-box. > > TBR=wangxianzhu@chromium.org > > (cherry picked from commit 22fb320e982b11fa75e4fe162a5261c56715d873) > > Bug: 888534 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iafb4fe1f61b007209f7be8963686996b5a50dbf7 > Reviewed-on: https://chromium-review.googlesource.com/1240742 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#593718} > Reviewed-on: https://chromium-review.googlesource.com/1243808 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/branch-heads/3497@{#966} > Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: Ic0d6bb0b46ba3550b07418bda0dbbbb35a06e347 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888534 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1243676 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#967} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
,
Sep 25
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 921eeecf4805b95e1224327dc54246e85f4c2930 was merged to refs/branch-heads/3497 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cf9967233d63c877dfa67f3264f52dbe125c8da commit 4cf9967233d63c877dfa67f3264f52dbe125c8da Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Sep 25 18:14:44 2018 [PE] Fix paint offset of floating object under display:-webkit-box The IsLayoutBlock() condition is now consistent with the floating object locationing logic (which is based on its containing block), and the condition covers display:-webkit-box. TBR=wangxianzhu@chromium.org (cherry picked from commit 22fb320e982b11fa75e4fe162a5261c56715d873) Bug: 888534 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iafb4fe1f61b007209f7be8963686996b5a50dbf7 Reviewed-on: https://chromium-review.googlesource.com/1240742 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593718} Reviewed-on: https://chromium-review.googlesource.com/1243677 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#656} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [add] https://crrev.com/4cf9967233d63c877dfa67f3264f52dbe125c8da/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box-expected.html [add] https://crrev.com/4cf9967233d63c877dfa67f3264f52dbe125c8da/third_party/WebKit/LayoutTests/paint/float/relative-float-under-webkit-box.html [modify] https://crrev.com/4cf9967233d63c877dfa67f3264f52dbe125c8da/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
,
Sep 25
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cf9967233d63c877dfa67f3264f52dbe125c8da Commit: 4cf9967233d63c877dfa67f3264f52dbe125c8da Author: wangxianzhu@chromium.org Commiter: wangxianzhu@chromium.org Date: 2018-09-25 18:14:44 +0000 UTC [PE] Fix paint offset of floating object under display:-webkit-box The IsLayoutBlock() condition is now consistent with the floating object locationing logic (which is based on its containing block), and the condition covers display:-webkit-box. TBR=wangxianzhu@chromium.org (cherry picked from commit 22fb320e982b11fa75e4fe162a5261c56715d873) Bug: 888534 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iafb4fe1f61b007209f7be8963686996b5a50dbf7 Reviewed-on: https://chromium-review.googlesource.com/1240742 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593718} Reviewed-on: https://chromium-review.googlesource.com/1243677 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#656} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 5
Rejecting merge to M69 as we're not planning any more M69 release. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vamshi.kommuri@chromium.org
, Sep 24