views_mus_interactive_ui_tests and views_mus_unittests are failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) Click to expand |
||||||
Issue descriptione.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29149 which includes Indirect leak of 1440 byte(s) in 2 object(s) allocated from: #0 0x59bc42 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 #1 0x2d2ea83 in mojo::core::Core::GetNodeController() mojo/core/core.cc:156:28 #2 0x2d2e942 in mojo::core::Core::SetIOTaskRunner(scoped_refptr<base::TaskRunner>) mojo/core/core.cc:150:3 #3 0x6c582ca in mojo::core::ScopedIPCSupport::ScopedIPCSupport(scoped_refptr<base::TaskRunner>, mojo::core::ScopedIPCSupport::ShutdownPolicy) mojo/core/embedder/scoped_ipc_support.cc:28:16 #4 0x2f3d847 in make_unique<mojo::core::ScopedIPCSupport, scoped_refptr<base::SingleThreadTaskRunner>, mojo::core::ScopedIPCSupport::ShutdownPolicy> buildtools/third_party/libc++/trunk/include/memory:3114:32 #5 0x2f3d847 in ServiceManagerConnection ui/views/mus/views_mus_test_suite.cc:78 #6 0x2f3d847 in PlatformTestHelperMus ui/views/mus/views_mus_test_suite.cc:171 #7 0x2f3d847 in make_unique<views::(anonymous namespace)::PlatformTestHelperMus> buildtools/third_party/libc++/trunk/include/memory:3114 #8 0x2f3d847 in views::(anonymous namespace)::CreatePlatformTestHelper() ui/views/mus/views_mus_test_suite.cc:223
,
Sep 25
The tests in views_mus_interactive_ui_tests started leaking after this patch. commit aefd808a350f919fd976f1187bc1fedec1845241 Author: Scott Violet <sky@chromium.org> Date: Tue Sep 26 00:38:29 2017 +0000 chromeos: make catalog service directory requests on background thread The requests do file system access, which shouldn't run on the thread Catalog runs on (IO thread). BUG= 763529 TEST=none Change-Id: Ie5324370fde6ed8ad8206de40190b4a1c3bf5676 Reviewed-on: https://chromium-review.googlesource.com/682648 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#504236} I don't know why the leak has not been detected until 9/22/2018. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=views_mus_interactive_ui_tests&builder=chromium.memory%3ALinux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1) sky@ Could you please handle this?
,
Sep 26
Issue 889397 has been merged into this issue.
,
Sep 26
Tests have been consistently failing[1] since 9/21, reporting memory leaks starting with build [2]. I haven't been able to determine the culprit CL from the blame list. [1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29105 [2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29?limit=200
,
Sep 26
,
Sep 26
horo, what makes you think that year old patch is the culprit? I can't see to reproduce this failure locally.
,
Sep 26
The attached log file is how I find that aefd808a350f919fd976f1187bc1fedec1845241 caused this failure locally.
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d332658fe13ab3c1802633ce8b4e25be3c0c9bc1 commit d332658fe13ab3c1802633ce8b4e25be3c0c9bc1 Author: Scott Violet <sky@chromium.org> Date: Thu Sep 27 20:42:00 2018 views: fix leaks in views_mus_unittests views_mus_unittests was calling mojo::core::Init() multiple times, which leaks. The fix is to move the Init() call to the TestSuite as well as setting up the ipc thread. BUG= 888533 TEST=test only changes Change-Id: I852ca0ab4736aa7a4a18d3c650fa6122b320eb9d Reviewed-on: https://chromium-review.googlesource.com/1249810 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#594847} [modify] https://crrev.com/d332658fe13ab3c1802633ce8b4e25be3c0c9bc1/ui/views/mus/views_mus_test_suite.cc [modify] https://crrev.com/d332658fe13ab3c1802633ce8b4e25be3c0c9bc1/ui/views/mus/views_mus_test_suite.h
,
Sep 27
These two test suites passed on the latest run. YAY! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jbroman@chromium.org
, Sep 24