New issue
Advanced search Search tips

Issue 888493 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Sep 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Error message is not seen for hyphen entries in 'Pages' textfield

Reported by khushal....@etouch.net, Sep 24 
Chrome Version: 71.0.3559.0 (Official Build) Revision 3bdc2dd56448262e33bd56e87998b4a26af69141-refs/branch-heads/3559@{#1} (64-bit)

OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Windows (7, 8, 8.1, 10) & Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome and press 'Cmd+P' to open Print Preview.
(2) Now click on the textbox of 'Pages' section and enter hyphens (-----) in textbox.
(3) Observe. 

Actual Result: Error message is not seen for hyphen entries in textbox.

Expected Result: Error message should be seen for hyphens (--) in textbox.

This is a regression issue, broken in M-71 series, below is manual regression range:
Good build: 71.0.3558.0
Bad build:  71.0.3559.0

(Unable to provide bisect using Per-revision script as "RuntimeError: We don't have enough builds to bisect" error message is thrown. Also, tried bisecting on other machines and same error is thrown. Hence, providing suspect using Chromium bisect)

Chromium Bisect info:

You are probably looking for a change made after 593390 (known good), but no later than 593404 (first known bad).

CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/ca9042e14b381271ea4be6e3a6c1c3920d9dd37d..21eea353daea69d467fbe830aa9cc7aee0fa6cf3

Suspecting: r593403 ??

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mov
6.7 MB View Download
Expected Video.mov
5.7 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4970413d8808b5a5ecc191127bdc9e736d2f8229

commit 4970413d8808b5a5ecc191127bdc9e736d2f8229
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Sep 25 18:20:34 2018

Print Preview Refresh: Fix some pages and link container polish bugs

- Make cr-input full height of radio button so there is no border
area where the hand pointer appears.
- Ignore pointer events on link container when disabled.
- Fix bug where "----" was considered valid input in pages.

Bug:  884603 ,  887823 ,  888493 
Change-Id: Ie9b7f2c42b12d7e2a7026f405b1a61b774578589
Reviewed-on: https://chromium-review.googlesource.com/1242037
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594013}
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/test/data/webui/print_preview/pages_settings_test.js

Comment 2 by rbpotter@chromium.org, Sep 27

Status: Fixed (was: Assigned)
Tested and this is fixed in Canary 71.0.3563.0.
►

Sign in to add a comment