Issue metadata
Sign in to add a comment
|
Regression: Password suggestion drop-down flickers when clicked on password field.
Reported by
aiman.an...@etouch.net,
Sep 24
|
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3559.0 (Official Build) 3bdc2dd56448262e33bd56e87998b4a26af69141-refs/branch-heads/3559@{#1} 64 bit OS: Mac(10.12.6, 10.13.1, 10.14, 10.13.6). Pre-condition: 1. Enable '#Automatic Password Generation' flag from chrome://flags page and Relaunch Chrome. 2. Sign-In to Chrome Browser with valid credentials What steps will reproduce the problem? 1. Open NTP, and navigate to www.flipkart.com. 2. Open Sign-UP Overlay, Enter mobile number with valid country code and click on 'Continue' button. 3. Click on Password field and select the auto-generated password. 4. Again click on password field to edit the auto-generated password. 5. Observe the password suggestion box and Sign-Up button. Actual Result: Password suggestion drop-down flickers when clicked on password field. (Sign-Up button is seen on flickering) Expected Result: Password suggestion drop-down should not flicker when clicked on password field. This is a regression issue broken in ‘M-69’ and soon update other info. Good Build: 68.0.3440.0(Revision:561734) Bad Build: 69.0.3441.0(Revision:562090) Note : 1. Able to reproduce issue in Stable #69.0.3497.100, Beta #70.0.3538.22 and Dev build #71.0.3554.0 2. Issue is only Mac OS specific and is not reproducible on Windows(7, 8, 8.1 ,10), Linux(14.04 LTS). Kindly refer the screen-cast from given link. https://drive.google.com/drive/folders/1Cl3xIEIj-79fy4WV2ZhmdDUB5sb5eBe2?usp=sharing Thank You!
,
Sep 25
,
Sep 25
r561870 cannot be related, since it only affects the payload of crowdsourcing votes, none of which is uploaded in this case. I don't see an obvious culprit in the revision list either, sorry.
,
Sep 25
,
Oct 4
The behavior is caused by BubbleCloser introduced in https://chromium-review.googlesource.com/c/chromium/src/+/974106. Note that AutofillExternalDelegate::DidEndTextFieldEditing code path works fine if I move the focus with the keyboard. Guys, why do we need this code then?
,
Oct 4
+cc spqchan@ for context also
,
Oct 4
It's to dismiss the popup when the window is moved. If that works fine without it, feel free to remove it
,
Oct 5
It works without it, I'll remove.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c68384cbee96ae30c208c562d3c1836c211909a commit 8c68384cbee96ae30c208c562d3c1836c211909a Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Oct 05 15:25:38 2018 Fix password suggestion drop-down flicker. The dropdown shouldn't be closed on random clicks on Mac. The focus changes are already handled by the cross-platform code. Bug: 888491 Change-Id: Ic5d40f7de3ae32270716e2df33e9944a1120bc75 Reviewed-on: https://chromium-review.googlesource.com/c/1264595 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597135} [modify] https://crrev.com/8c68384cbee96ae30c208c562d3c1836c211909a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/8c68384cbee96ae30c208c562d3c1836c211909a/chrome/browser/ui/views/autofill/autofill_popup_base_view.h
,
Nov 7
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Sep 24