* Previous roll:  issue 880827 

Probably also want to resolve the windows libfuzzer questions before rolling again (https://bugs.chromium.org/p/chromium/issues/detail?id=880827#c28 , https://chromium-review.googlesource.com/c/chromium/src/+/1229078#message-db9a8216caac1bccf611340e920d4e1fa2770cec)

I'd say go on without https://reviews.llvm.org/D52217 and https://reviews.llvm.org/D51664 if you're ready to roll otherwise.

 Issue 889080  has been merged into this issue.

Attempting packaging: https://chromium-review.googlesource.com/c/chromium/src/+/1245465

New package and tryjobs: https://chromium-review.googlesource.com/c/chromium/src/+/1245465

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c58d162bce2af84b2ec900fe9d66ae17c3ae8ad

commit 7c58d162bce2af84b2ec900fe9d66ae17c3ae8ad
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Sep 27 17:24:26 2018

Roll clang 342523:343189.

Bug:  888476 
Change-Id: Iccb39603a10261d1bdf3fcb26b008bb02fc371e6
Reviewed-on: https://chromium-review.googlesource.com/1245465
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594765}
[modify] https://crrev.com/7c58d162bce2af84b2ec900fe9d66ae17c3ae8ad/tools/clang/scripts/update.py

Some nacl tests became flaky under win-asan after the roll, see  Issue 890150 

That's probably not revert-worthy though.

Actually there are consistent test failures on Windows ASAN following a build containing this roll. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/1584

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dcaa8f8a20e48e280bd0a0a67f080dc481e3325

commit 7dcaa8f8a20e48e280bd0a0a67f080dc481e3325
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Sep 28 14:31:40 2018

Revert "Roll clang 342523:343189."

This reverts commit 7c58d162bce2af84b2ec900fe9d66ae17c3ae8ad.

Reason for revert:
This broke win-asan, see 2nd bug.

Original change's description:
> Roll clang 342523:343189.
> 
> Bug:  888476 
> Change-Id: Iccb39603a10261d1bdf3fcb26b008bb02fc371e6
> Reviewed-on: https://chromium-review.googlesource.com/1245465
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594765}

TBR=thakis@chromium.org,hans@chromium.org

Change-Id: I003bbfca7a542fe18c31a679ea58cf1da2c3fdb3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  888476 ,  890310 
Reviewed-on: https://chromium-review.googlesource.com/1251606
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595081}
[modify] https://crrev.com/7dcaa8f8a20e48e280bd0a0a67f080dc481e3325/tools/clang/scripts/update.py

Next attempt: https://chromium-review.googlesource.com/c/chromium/src/+/1251466

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6cfd8de17d86bec45b104fc11bf04a3da2532ea

commit c6cfd8de17d86bec45b104fc11bf04a3da2532ea
Author: Hans Wennborg <hans@chromium.org>
Date: Sat Sep 29 22:26:00 2018

Roll Clang 342523:343342

Bug:  888476 
Change-Id: I2d95b71010226218631dab88b536fb00669db190
Reviewed-on: https://chromium-review.googlesource.com/1251466
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595334}
[modify] https://crrev.com/c6cfd8de17d86bec45b104fc11bf04a3da2532ea/build/config/compiler/BUILD.gn
[modify] https://crrev.com/c6cfd8de17d86bec45b104fc11bf04a3da2532ea/tools/clang/scripts/update.py

It appears to be sticking. Next roll:  Issue 891181 

Just for the record, this roll broke coverage builds for many targets (issue 891320), but ToT testbots were lucky enough to be building only the targets that succeeded.

We'll extend the list of targets used by the testbots (issue 891322) to make cases like this less probable in future.

Not sure what we can do for now. I guess we can't demand the revert, given that our bots are green, but leaving the code coverage configuration broken for a couple weeks is also not an option.

Unfortunately I'm OOO and don't have time right now to dive into details and try to figure out a fix for this.

Is it fixed upstream? We want to roll again soonish to fix a few configs, so your best bet is probably to make sure that upstream is happy.

Yuke, can you please take a look on what regressed this. This culprit cl on llvm side can be just reverted and then we can wait on next upcoming clang roll (soon as per Nico).

sure

Sorry for the noise, apparently c#22 was incorrect, the real root cause was some code landed in Chromium that was crashing clang when compiling with coverage instrumentation. Thanks everyone for the help!