New issue
Advanced search Search tips

Issue 888465 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 25
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Unable to open 'Select a destination' overlay using 'Enter' key.

Reported by dchau...@etouch.net, Sep 24 
Chrome Version: 71.0.3559.0 (Official Build) Revision	3bdc2dd56448262e33bd56e87998b4a26af69141-refs/branch-heads/3559@{#1} (32/64-bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs).

What steps will reproduce the problem?
1. Launch Chrome and give print command on any web-page.
2. Bring focus on 'Change' button using 'Tab' key.
3. Now press standard 'Enter' key from keyboard and observe.

Actual: 'Select a destination' overlay doesn't open and 'Print preview' page gets closed on pressing standard 'Enter' key.
Expected: 'Select a destination' overlay should get opened on pressing standard 'Enter' key from keyboard.

This is a regression issue, broken in M-71 series, below is manual regression range:

Good build: 71.0.3551.0 (Revision: 590851)
Bad build: 71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
472 KB View Download
Expected behavior.mp4
616 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d55e69819faffc4c086e81b3dec8530839239c

commit a9d55e69819faffc4c086e81b3dec8530839239c
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Sep 24 22:18:35 2018

Print Preview Refresh: Fix cut off cr-input in advanced dialog

Also fix a bug where enter still leads to print if one of the
paper-buttons on the page is focused (should open dialog instead).
Previously print preview did not have paper-buttons, so  did not check
this case.

Bug:  887844 ,  888465 
Change-Id: Ie041ace8ea0fd5d62096331efba727af55e935f5
Reviewed-on: https://chromium-review.googlesource.com/1239365
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593713}
[modify] https://crrev.com/a9d55e69819faffc4c086e81b3dec8530839239c/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[modify] https://crrev.com/a9d55e69819faffc4c086e81b3dec8530839239c/chrome/browser/resources/print_preview/new/app.js

Comment 2 by dchau...@etouch.net, Sep 25

Labels: TE-Verified-M71 TE-Verified-71.0.3561.0
Updated:
Re-tested this issue on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) machines using latest Canary build #71.0.3561.0 and the issue is fixed. Hence adding TE-Verified labels. 

Kindly review an attached screen-cast for reference.

Thank you..!
Fixed behavior.mp4
512 KB View Download

Comment 3 by rbpotter@chromium.org, Sep 25

Status: Verified (was: Assigned)
►

Sign in to add a comment