Issue metadata
Sign in to add a comment
|
Regression: Unnecessary hand pointer with unnecessary focus when clicked is seen at disabled Overwrite original checkbox in Files app |
||||||||||||||||||||||
Issue descriptionChrome Version:71.0.3558.0/11094.0.0 dev channel Reks,Daisy,Kip OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >>Take a sample screenshot >>Open with Gallery (2)Edit >> do some edit & save >> hover the mouse at Overwrite original and observe Actual: Unnecessary hand pointer is seen at disabled Overwrite original checkbox and when clicked unnecessary focus is seen on it Expected: No such unnecessary focus and hand pointer should be seen at disabled Overwrite original checkbox This is a Regression issue as same is working fine in M-67 Note: Issue is seen in M-68,M-69,M-70 Attached screencast for reference..
,
Sep 25
we should bisect this (see https://crbug.com/663450#c19 ). I'm guessing r556293 r556560 or something nearby. They're in the m67-m68 range (550428: 561733). Note this is a cr-checkbox.
,
Sep 27
,
Sep 27
,
Oct 3
I think this is Gallery app specific?
,
Nov 5
I think I might have a fix ready for this. https://chromium-review.googlesource.com/c/chromium/src/+/1318062 I updated the cr-checkbox
,
Nov 7
,
Nov 8
,
Nov 8
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fffd2c0099a0bbb6a4239fba83e8a3f26c3878b commit 0fffd2c0099a0bbb6a4239fba83e8a3f26c3878b Author: Alexander Nohe <nohe@chromium.org> Date: Fri Nov 09 00:43:51 2018 Remove the pointer cursor and focus state Removed the pointer cursor and focus state when the checkbox is disabled. This should prevent the checkbox from maintaining any unnecessary focus as well as preventing any confusion when hovering over the overwrite changes checkbox. Bug: 888464 Change-Id: I14547deb878f2948e5606f3bf0bbc01b9ba75886 Reviewed-on: https://chromium-review.googlesource.com/c/1318062 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#606674} [modify] https://crrev.com/0fffd2c0099a0bbb6a4239fba83e8a3f26c3878b/ui/file_manager/gallery/css/gallery.css [modify] https://crrev.com/0fffd2c0099a0bbb6a4239fba83e8a3f26c3878b/ui/file_manager/integration_tests/gallery/photo_editor.js
,
Nov 9
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by slangley@chromium.org
, Sep 24