Issue metadata
Sign in to add a comment
|
Regression: Grey focus remains on 'Gmail' option even after traversing to other elements in the bookmark bar using tab.
Reported by
vineetha...@etouch.net,
Sep 24
|
||||||||||||||||||||||
Issue descriptionChrome version : 71.0.3559.0 (Official Build) Revision 3bdc2dd56448262e33bd56e87998b4a26af69141-refs/branch-heads/3559@{#1}(32/64-bit) OS : Win(7,8,8.1,10)OS Pre-condition: Fresh launch chrome by enabling command line flag --enable-features=NuxGoogleApps . Steps to reproduce: 1. Observe, chrome gets launched with page chrome://welcome/apps. 2. Click on 'Get started' button and observe inkdrop(grey) focus. Actual Result : Grey focus remains on 'Gmail' bookmark even when focus is taken to other bookmarks( or other elements on the page) after pressing tab key. Expected Result: Grey focus should not remain on 'Gmail' bookmark when tab focus is traversed through the page. This is a regression issue broken in ‘M-71’ and will soon update bisect info. Good build: 71.0.3555.0(Revision: 591861) Bad build : 71.0.3556.0(Revision: 592301) You are probably looking for a change made after 592983 (known good), but no later than 592984 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e62b9095fe750f3dad440f98c5775c4f6ac4f165..e767f87e7a62609817cff5bce1de36a4d60dfbd5 Suspecting : https://chromium.googlesource.com/chromium/src/+/e767f87e7a62609817cff5bce1de36a4d60dfbd5 @corising : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the attached screen-cast. Thank you! Note: Issue is specific to Windows OS.
,
Sep 27
,
Sep 27
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aff37c6252d7af8604e1d90e08cc914a057a38b9 commit aff37c6252d7af8604e1d90e08cc914a057a38b9 Author: Caroline Rising <corising@chromium.org> Date: Fri Sep 28 18:34:20 2018 Remove button highlighting for promo bubbles. Highlighting was previously added to buttons with anchored widgets. This is not the desired effect for promo buttons. This change makes the highlighted function overridable and removes the button highlight for the feature promo bubbles. Bug: 888462 Change-Id: I79077bf9e7f30543eee6ae87db0785e9a0e08051 Reviewed-on: https://chromium-review.googlesource.com/1246144 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#595164} [modify] https://crrev.com/aff37c6252d7af8604e1d90e08cc914a057a38b9/chrome/browser/ui/views/feature_promos/feature_promo_bubble_view.h [modify] https://crrev.com/aff37c6252d7af8604e1d90e08cc914a057a38b9/ui/views/bubble/bubble_dialog_delegate_view.h
,
Sep 28
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by robliao@chromium.org
, Sep 26