New issue
Advanced search Search tips

Issue 888454 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Background Fetch] Add UKM metric for user-initiated cancellations

Project Member Reported by na...@chromium.org, Sep 24

Issue description

Status: Started (was: Untriaged)
Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.
Project Member

Comment 3 by bugdroid1@chromium.org, Today (17 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f367101bcdb7a7045d91721965e8bd756b1458e

commit 1f367101bcdb7a7045d91721965e8bd756b1458e
Author: Mugdha Lakhani <nator@chromium.org>
Date: Tue Jan 22 16:04:09 2019

[Background Fetch] UKM for user initiated aborts.

This adds the logic to log a UKM event, BackgroundFetchDeletingRegistration.

We look for the origin of background fetch in the HistoryService database.
If there's a match, a new SourceId with the origin as the URL is used to log
the UKM data.

UKM collection review:
https://docs.google.com/document/d/1BdKDxQnhanCqzgeflH_V71HuepcZtJwzzDqmgU85JeA/edit?usp=sharing

Bug:  888454 
Change-Id: Ie17dd97fc60614e3c7e1517e6dab84b6fe7b461b
Reviewed-on: https://chromium-review.googlesource.com/c/1391916
Commit-Queue: Mugdha Lakhani <nator@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624794}
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[add] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/chrome/browser/background_fetch/background_fetch_delegate_impl_unittest.cc
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/chrome/test/BUILD.gn
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/content/browser/background_fetch/background_fetch_scheduler.cc
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/1f367101bcdb7a7045d91721965e8bd756b1458e/tools/metrics/ukm/ukm.xml

Comment 4 by na...@chromium.org, Today (16 hours ago)

Status: Fixed (was: Available)

Sign in to add a comment