New issue
Advanced search Search tips

Issue 888451 link

Starred by 1 user
Status: Assigned
Owner:
pmarko@chromium.org
Cc:
hendrich@chromium.org
emaxx@chromium.org
steve...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Separate Client and Authority certificates in CertLoader, rename to NetworkCertLoader

Project Member Reported by pmarko@chromium.org, Sep 24 
Currently, CertLoader makes client and authority certificates available through its all_certs() accessor. NetworkCertificateHandler then separates the two kinds of certificate.

Instead it probably makes sense to change CertLoader to provide all_client_certificates() and authority_certificates() separately, because no consumer needs a mixed list.

While we're at it, we should rename CertLoader to e.g. NetworkCertLoader and add a class-level comment that it makes certificates available to Network handling on ChromeOS.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5006c4c906e0e3925bd690951a07124f7f9808b0

commit 5006c4c906e0e3925bd690951a07124f7f9808b0
Author: Pavol Marko <pmarko@chromium.org>
Date: Tue Oct 09 12:58:10 2018

Rename CertLoader to NetworkCertLoader

|NetworkCertLoader| is used to make certificates from the 'system' token
and the primary user's 'user' token available for network connections
(e.g. EAP-TLS) on Chrome OS. |CertLoader| was a very unspecific name.

Bug: 888451
Test: compile
Change-Id: I8291166e896bd7e905039922c7d0b3dbb24e72d8
Reviewed-on: https://chromium-review.googlesource.com/c/1259642
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597891}
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/ash/system/network/auto_connect_notifier_unittest.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chrome/browser/chromeos/policy/user_network_configuration_updater.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chrome/browser/chromeos/policy/user_network_configuration_updater_factory_browsertest.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/BUILD.gn
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/auto_connect_handler_unittest.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/client_cert_resolver.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/client_cert_resolver.h
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/client_cert_resolver_unittest.cc
[rename] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_cert_loader.cc
[rename] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_cert_loader.h
[rename] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_cert_loader_unittest.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_cert_migrator.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_cert_migrator.h
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_cert_migrator_unittest.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_certificate_handler.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_certificate_handler.h
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_connection_handler_impl_unittest.cc
[modify] https://crrev.com/5006c4c906e0e3925bd690951a07124f7f9808b0/chromeos/network/network_handler.cc
►

Sign in to add a comment