Port chromium.webrtc tests so they run on swarming |
|||
Issue descriptionThe browser_tests_apprtc step has to have swarming disabled for now since it relies on gclient runhooks to download and build the AppRTC server and collider etc. Find some way to make this work on swarmed machines. This means building and isolating collider and the google cloud sdk. Test code: https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_apprtc_browsertest.cc?q=apprtc_bro&sq=package:chromium&g=0&l=1 Runhooks code: https://webrtc.googlesource.com/webrtc.DEPS/+/master/DEPS#8 https://cs.chromium.org/chromium/src/third_party/webrtc/rtc_tools/testing/?q=setup_apprtc&sq=package:chromium&g=0
,
Sep 24
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf9213185f4b30e2467ada974274a0eae7ccd601 commit bf9213185f4b30e2467ada974274a0eae7ccd601 Author: Patrik Höglund <phoglund@chromium.org> Date: Tue Sep 25 10:27:46 2018 Force apprtc test to run locally for now. It runs locally in the old BuildBot waterfall as well, so let's keep it that way until we can get time to port this test. Bug: 888429, 877018 Change-Id: I78b4bf6a2205c7c77ccf4f681f4f53bca2879f20 Reviewed-on: https://chromium-review.googlesource.com/1240273 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#593884} [modify] https://crrev.com/bf9213185f4b30e2467ada974274a0eae7ccd601/testing/buildbot/chromium.webrtc.fyi.experimental.json [modify] https://crrev.com/bf9213185f4b30e2467ada974274a0eae7ccd601/testing/buildbot/test_suites.pyl
,
Oct 1
It seems that Swarming bots always take a long time to download the 6960 files. Caching will probably not help much because there are 1540 bots in the pool, and the cache will also be invalidated by any change in browser_tests. Are we sure that using Swarming is the right thing to do? It works on LUCI without it anyway.
,
Oct 1
Ok then, maybe we should keep it as is then. I think the main problem is that we have to use the old-style package/extract_build steps in the bots, which are deprecated to my knowledge. Another solution could be to get a dedicated bot_group with maybe two bots that runs apprtc tests so that caching becomes more effective. Isn't it possible to cache apprtc separate from browser_tests? I'm fine with keeping it as is and closing this bug. Your call.
,
Oct 16
Ok, we should port the AppRTC test and make the current chromium.webrtc bots swarmed, so repurposing this bug for that.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af4a07700c3397b01ac65266d118b357023fd522 commit af4a07700c3397b01ac65266d118b357023fd522 Author: Patrik Höglund <phoglund@chromium.org> Date: Wed Oct 17 13:29:55 2018 Temporarily remove perf browsertests. Let's try adding these from the recipes while we figure out a better solution. Tbr: kbr@chromium.org Bug: 888429 Change-Id: I1a3c8c4a7ba326dbcb2c4c3058a0f3272198ab0d Reviewed-on: https://chromium-review.googlesource.com/c/1286134 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#600373} [modify] https://crrev.com/af4a07700c3397b01ac65266d118b357023fd522/testing/buildbot/chromium.webrtc.json [modify] https://crrev.com/af4a07700c3397b01ac65266d118b357023fd522/testing/buildbot/test_suites.pyl
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/df78c5197a24b8eb507312d5df4e5b5156605e21 commit df78c5197a24b8eb507312d5df4e5b5156605e21 Author: Patrik Höglund <phoglund@chromium.org> Date: Wed Oct 17 13:34:05 2018 Temporarily add back browser tests to chromium.webrtc bots. It appears they stop uploading to the perf dashboard in test_suites.pyl. Let's put them back and remove from test_suites.pyl for now while we figure out a better solution. Hopefully this means it will take one test from this config and the others from test_suites.pyl. Bug: chromium:877018 , chromium:888429 Tbr: kbr@chromium.org Change-Id: I0e589457a3f29d7bd8fa5326a8947e838e9dc80c Reviewed-on: https://chromium-review.googlesource.com/c/1286458 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by: Patrik Höglund <phoglund@chromium.org> [modify] https://crrev.com/df78c5197a24b8eb507312d5df4e5b5156605e21/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by phoglund@chromium.org
, Sep 24