New issue
Advanced search Search tips

Issue 888425 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 24
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DISABLE_ typo

Project Member Reported by battre@chromium.org, Sep 24

Issue description

I have seen a number of cases where an attempt has been made to disable a test by using "DISABLE_" instead of "DISABLED_" as a prefix. It should be able to fix that with a presubmit script.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/033531055256a55715e08b9a999099f20051c8a1

commit 033531055256a55715e08b9a999099f20051c8a1
Author: Dominic Battre <battre@chromium.org>
Date: Mon Sep 24 15:45:34 2018

Presubmit script that warns in case of DISABLE_ prefixes

In the past 2 weeks I had one case where I, as a sheriff, tried to disable a
test with a "DISABLE_" prefix (should be "DISABLED_") and one case, where I was
TBRs on someone elses' typo. This presubmit script warns the committer in these
cases (C++ only for now).

Bug:  888425 
Change-Id: Iff555a90db674ecd4df77819f1fa82270fbd715d
Reviewed-on: https://chromium-review.googlesource.com/1240279
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593549}
[modify] https://crrev.com/033531055256a55715e08b9a999099f20051c8a1/PRESUBMIT.py
[modify] https://crrev.com/033531055256a55715e08b9a999099f20051c8a1/PRESUBMIT_test.py

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f13948e30bab4ed44a3454064d28d91f9300f252

commit f13948e30bab4ed44a3454064d28d91f9300f252
Author: Katie D <katie@chromium.org>
Date: Tue Sep 25 07:33:44 2018

Fix _CheckNoDISABLETypoInTests when test file is deleted.

TBR=jochen@chromium.org

Bug:  888425 
Change-Id: I8ff979ae3d969ccff7ca9cbb1ec1deb86f65535a
Reviewed-on: https://chromium-review.googlesource.com/1241956
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593847}
[modify] https://crrev.com/f13948e30bab4ed44a3454064d28d91f9300f252/PRESUBMIT.py
[modify] https://crrev.com/f13948e30bab4ed44a3454064d28d91f9300f252/PRESUBMIT_test.py

Sign in to add a comment