DISABLE_ typo |
||
Issue descriptionI have seen a number of cases where an attempt has been made to disable a test by using "DISABLE_" instead of "DISABLED_" as a prefix. It should be able to fix that with a presubmit script.
,
Sep 24
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f13948e30bab4ed44a3454064d28d91f9300f252 commit f13948e30bab4ed44a3454064d28d91f9300f252 Author: Katie D <katie@chromium.org> Date: Tue Sep 25 07:33:44 2018 Fix _CheckNoDISABLETypoInTests when test file is deleted. TBR=jochen@chromium.org Bug: 888425 Change-Id: I8ff979ae3d969ccff7ca9cbb1ec1deb86f65535a Reviewed-on: https://chromium-review.googlesource.com/1241956 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#593847} [modify] https://crrev.com/f13948e30bab4ed44a3454064d28d91f9300f252/PRESUBMIT.py [modify] https://crrev.com/f13948e30bab4ed44a3454064d28d91f9300f252/PRESUBMIT_test.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 24