New issue
Advanced search Search tips

Issue 888419 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression : Unable to navigate to 'Site details' sub-page through 'Enter' key.

Reported by avsha...@etouch.net, Sep 24

Issue description

Chrome Version : 71.0.3559.0 (Official Build) 3bdc2dd56448262e33bd56e87998b4a26af69141-refs/branch-heads/3559@{#1} 32/64 bit
OS : Windows(7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6), Linux(14.04 LTS)

Pre-condition : Enable '#site-settings' flag from chrome://flags page.

What steps will reproduce the problem?
1. Launch chrome, open NTP, click on 'Microphone' icon in fake box and allow the permission. (Cookie entry gets created in 'All sites')
2. Navigate to chrome://settings/content/all and press 'Tab' key to bring focus on arrow icon of first site entry (www.google.co.in) present on 'All sites' page.
3. Now hit 'Enter' key and observe.

Actual Result : Unable to navigate to 'Site details' sub-page through 'Enter' key. (instead, blue ring appears on a site entry and nothing happens with 'Enter' key)

Expected Result : Page should navigate to 'Site details' sub-page via 'Enter' key while focus is on arrow icon of site entry. 

This is a regression issue broken in ‘M-70’ and below is the 'per-revision' bisect information.
Good Build : 70.0.3503.0 (Revision : 578160)
Bad Build : 70.0.3504.0 (Revision : 578510)

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/654cef29bbfcb7445645b18e9e2c9530853fe4e6..00aa4484f993bfd9c8525f5bb8d075b44f8e023b

Suspecting : https://chromium.googlesource.com/chromium/src/+/00aa4484f993bfd9c8525f5bb8d075b44f8e023b

Patti@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note :
1. Able to reproduce issue in Beta #70.0.3538.22 and Dev build #71.0.3554.0
 
Actual_Result.mp4
583 KB View Download
Expected_Result.mp4
828 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01409c44be2182fe90d608a0ca7bb23b2796382e

commit 01409c44be2182fe90d608a0ca7bb23b2796382e
Author: Maggie Cai <mxcai@chromium.org>
Date: Tue Jan 08 03:01:32 2019

Settings: Fix the navigation through 'Enter' key on All Sites page.

Currently unable to navigate to 'Site details' sub-page through 'Enter'
key on All Sites page for each site entry.This CL fixes this issue.

BUG= 888419 

Change-Id: I1bfbecb66bb876dea9c4abbda299a00b91f7f0b6
Reviewed-on: https://chromium-review.googlesource.com/c/1397501
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620593}
[modify] https://crrev.com/01409c44be2182fe90d608a0ca7bb23b2796382e/chrome/browser/resources/settings/site_settings/all_sites.html
[modify] https://crrev.com/01409c44be2182fe90d608a0ca7bb23b2796382e/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/01409c44be2182fe90d608a0ca7bb23b2796382e/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/01409c44be2182fe90d608a0ca7bb23b2796382e/chrome/browser/resources/settings/site_settings/site_entry.js

Labels: TE-Verified-M73 TE-Verified-73.0.3666.0
Update :
---------

Verified above issue in latest Canary build #73.0.3666.0 on Mac(10.13.1, 10.13.6, 10.14.3), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed.
Kindly review an attached screen-cast for reference.

Thank you..!
Canary_behaviour.mov
5.5 MB View Download

Comment 3 by mxcai@chromium.org, Jan 17 (5 days ago)

Cc: patricia...@chromium.org
Owner: mxcai@chromium.org
Status: Verified (was: Assigned)

Sign in to add a comment