New issue
Advanced search Search tips

Issue 888412 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 26
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] 'Print Destination' header gets hide on 'Select a destination' overlay.

Reported by dchau...@etouch.net, Sep 24 
Chrome Version: 71.0.3559.0 (Official Build) Revision	3bdc2dd56448262e33bd56e87998b4a26af69141-refs/branch-heads/3559@{#1} (32/64-bit)
OS: Windows(7,8,8.1,10) and Linux(14.04 LTs).

Pre-condition: At-least 5-6 Printer must be present under 'Print Destination' section.

What steps will reproduce the problem?
1. Launch Chrome, give print command on any webpage and click on 'Change' button to open 'Select a destination' overlay.
2. Bring focus on first printer under 'Print Destination' section using 'Tab' key from keyboard.
3. Now press down arrow key from keyboard till focus reached to it's last printer and observe.

Actual: 'Print Destination' header gets hide.
Expected: 'Print Destination' header should not hide.

This is a regression issue, broken in M-71 series, will soon update other info.

NOTE: This issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.6, 10.14) OS.

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
968 KB View Download
Expected behavior.mp4
720 KB View Download

Comment 1 by dchau...@etouch.net, Sep 24

Labels: hasbisect-per-revision
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range:

Good build: 71.0.3558.0 (Revision: 593043)
Bad build: 71.0.3558.0 (Revision: 593399)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 593249 (known good), but no later than 593250 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/401094d9d99a8404a9fde5791fc61ded27e03bbd..fa2e08937a5c741634ebb903330a5e46986a4532

Suspecting: https://chromium.googlesource.com/chromium/src/+/fa2e08937a5c741634ebb903330a5e46986a4532

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank you.
Dailog screenshot.png
45.7 KB View Download

Comment 2 by rbasuvula@chromium.org, Sep 24 

Correction:

Good build: 71.0.3558.0 (Revision: 593043)
Bad build: 71.0.3559.0 (Revision: 593399)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1364b08ca0a77d69006371192ee4626364acbffa

commit 1364b08ca0a77d69006371192ee4626364acbffa
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Sep 25 18:56:07 2018

Print Preview Refresh: Fix some destinations sizing issues

- Expand line heights & add margin so that the header is the right
height and the focus highlight for "Manage" doesn't get cut off.
- Set min-height 0 on the list container flex child so that it can
shrink. Otherwise, odd bugs occur since it stays the height of the
content.

Bug:  888411 ,  888412 
Change-Id: I4d61b7c5c2e41bacc29695f3588c20070182c16a
Reviewed-on: https://chromium-review.googlesource.com/1241973
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594030}
[modify] https://crrev.com/1364b08ca0a77d69006371192ee4626364acbffa/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/1364b08ca0a77d69006371192ee4626364acbffa/chrome/browser/resources/print_preview/new/destination_list.html

Comment 4 by dchau...@etouch.net, Sep 26

Labels: TE-Verified-M71 TE-Verified-71.0.3562.0
Updated:
Re-tested this issue on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) machines using latest Canary build #71.0.3562.0 and the issue is fixed. Hence adding TE-Verified labels. 

Kindly review an attached screen-cast for reference.

Thank you..!
Fixed behavior.mp4
809 KB View Download

Comment 5 by rbpotter@chromium.org, Sep 26

Status: Verified (was: Assigned)
►

Sign in to add a comment