New issue
Advanced search Search tips

Issue 888411 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 26
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Focus ring on 'Manage...' link appears chopped from top.

Reported by sanyam.g...@etouch.net, Sep 24 
Chrome Version: 71.0.3559.0 (Official Build) Revision	3bdc2dd56448262e33bd56e87998b4a26af69141-refs/branch-heads/3559@{#1} (32/64-bit)
OS: Windows(7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, press Ctrl + P to open print preview.
2. Click on 'Change' button to open 'Select a destination' overlay.
3. Press tab to bring focus on 'Manage...' link and observe. 

Actual Result  : Focus ring on 'Manage...' link appears chopped from top.
Expected Result: Focus ring on 'Manage...' link should not appear chopped.

This is a regression issue broken in ‘M-71’ and below is the  bisect information:
Good Build: 71.0.3556.0 (Revision: 592302)
Bad Build : 71.0.3557.0 (Revision: 592637)

You are probably looking for a change made after 592613 (known good), but no later than 592614 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/282b263f46a04b847af8ca36e359cb5c18574225..740492f9aba228edd794d7bd9d148d0929895a54

Suspect : https://chromium.googlesource.com/chromium/src/+/740492f9aba228edd794d7bd9d148d0929895a54

@rbpotter- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Actual_Result.mp4
504 KB View Download
Expected_Result.mp4
432 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1364b08ca0a77d69006371192ee4626364acbffa

commit 1364b08ca0a77d69006371192ee4626364acbffa
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Sep 25 18:56:07 2018

Print Preview Refresh: Fix some destinations sizing issues

- Expand line heights & add margin so that the header is the right
height and the focus highlight for "Manage" doesn't get cut off.
- Set min-height 0 on the list container flex child so that it can
shrink. Otherwise, odd bugs occur since it stays the height of the
content.

Bug:  888411 ,  888412 
Change-Id: I4d61b7c5c2e41bacc29695f3588c20070182c16a
Reviewed-on: https://chromium-review.googlesource.com/1241973
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594030}
[modify] https://crrev.com/1364b08ca0a77d69006371192ee4626364acbffa/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/1364b08ca0a77d69006371192ee4626364acbffa/chrome/browser/resources/print_preview/new/destination_list.html

Comment 2 by sanyam.g...@etouch.net, Sep 26

Labels: TE-Verified-M71 TE-Verified-71.0.3562.0
Updated:
Re-tested this issue on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) machines using latest Canary build #71.0.3562.0 and the issue is fixed. Hence adding TE-Verified labels. 

Kindly review an attached screen-cast for reference.

Thank you..!
Fixed_Behaviour.mp4
525 KB View Download

Comment 3 by rbpotter@chromium.org, Sep 26

Status: Verified (was: Assigned)
►

Sign in to add a comment