Old/New version textbox reversed and showing incorrect changelog @https://omahaproxy.appspot.com/ |
||||
Issue descriptionURL: https://omahaproxy.appspot.com/ Enter Old version and New Version as 71.0.3556.0 and 71.0.3557.0. Click on Show changelog and observe Chrome,V8,Skia Change Log. Expected: Should show the changes & correct changelog. Actual: Doesn't show the changes & correct changelog. Workaround: Looks like entering New version textbox with older build and Old version textbox with new build seems to work fine.
,
Sep 24
,
Sep 24
Maybe related to this recent-ish change to the changelog handling: https://crrev.com/i/648069
,
Sep 24
Yeah, these calls:
changelog = _GetChangeLog(
self.request.get('new_version'),
self.request.get('old_version'),
changelog = _GetChangeLog(current_info.version,
previous_info.version)
don't match the args order expected in:
def _GetChangeLog(old_version, new_version, is_webkit=False):
(which is reversed from the way it was before the refactoring)
,
Sep 24
,
Sep 24
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/d5ea3b3ad03a89b6b653fdc57715b6ed9d917d7b commit d5ea3b3ad03a89b6b653fdc57715b6ed9d917d7b Author: Michael Moss <mmoss@google.com> Date: Mon Sep 24 18:58:10 2018
,
Sep 24
Deployed.
,
Sep 26
Thanks for fixing this :) |
||||
►
Sign in to add a comment |
||||
Comment 1 by gov...@chromium.org
, Sep 24