New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 888397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 888402



Sign in to add a comment

Top candidate should be in the center and bold.

Project Member Reported by shend@chromium.org, Sep 24

Issue description

Chrome Version: 71.0.3554.0
OS: Chrome

What steps will reproduce the problem?
(1) Open VK.
(2) Type stuff.

What is the expected result?
Top candidate is shown in the middle in bold (see mocks).

What happens instead?
Top candidate is shown on the left and not bold.
 
Labels: -Pri-3 Pri-1
I think if this is a critical part of the intended UI, it should be P1.  iloahz@ can you check with fusong@?
yeah sure, i'll confirm this feature.
Hi pcovell@ and shend@,

Just confirmed with fusong@:
1. Top candidate should be put in the middle.
2. Bold is for auto-correction candidates.

Sometimes auto-correction feels like top candidates, e.g.:
Type: "hel"
Candidates:
hello, auto-correction: true
hel,   auto-correction: false
help,  auto-correction: false

Type: "hello"
Candidates:
hellos,   auto-correction: false
hello,    auto-correction: false
hello's,  auto-correction: false

In the 1st case, hello should be put in the middle and in bold font.
In the 2nd case, hellos would be in the middle, and no one is in bold.

I checked this is also how Android does.
Thank you
Blocking: 888402
Status: Fixed (was: Assigned)
Labels: M-71 M-70
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 28

Labels: Merge-Request-70
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 29

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 2

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/e67fe9ec393c3379b0b83a2209eeba9e88dda485

commit e67fe9ec393c3379b0b83a2209eeba9e88dda485
Author: Bao-Duy Tran <tranbaoduy@google.com>
Date: Tue Oct 02 07:30:21 2018

Project Member

Comment 13 by sheriffbot@chromium.org, Oct 5

Cc: wuyingbing@chromium.org geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 8

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70

Sign in to add a comment