Chormium build failed: Linkage error: error: undefined reference to 'SkRGBA4f<(SkAlphaType)3>::FromColor(unsigned int) |
|||||||
Issue description[ADD relevant info inline] Link to build or pfq page. build # for that buildbot. Snippet of log that contains the failure. ninja -C out/cOS chrome browser_tests nacl_helper -j 1120 -l 56 ninja: Entering directory `out/cOS' [5/1552] SOLINK ./libash.so FAILED: libash.so libash.so.TOC python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libash.so" --tocfile="./libash.so.TOC" --output="./libash.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -m64 -Werror -Wl,-O2 -Wl,--gc-sections -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libash.so" -Wl,-soname="libash.so" @"./libash.so.rsp" obj/ash/ash/accessibility_focus_ring_controller.o:accessibility_focus_ring_controller.cc:function ash::AccessibilityFocusRingController::SetHighlights(std::__1::vector<gfx::Rect, std::__1::allocator<gfx::Rect> > const&, unsigned int): error: undefined reference to 'SkRGBA4f<(SkAlphaType)3>::FromColor(unsigned int)' obj/ash/ash/accessibility_focus_ring_controller.o:accessibility_focus_ring_controller.cc:function ash::AccessibilityFocusRingController::GetColorAndOpacityFromColor(unsigned int, float, unsigned int*, float*): error: undefined reference to 'SkRGBA4f<(SkAlphaType)3>::FromColor(unsigned int)' clang: error: linker command failed with exit code 1 (use -v to see invocation) [7/1545] SOLINK ./libblink_core.so ninja: build stopped: subcommand failed.
,
Sep 24
,
Sep 24
First failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7937 I notice it has a Skia roll in it.
,
Sep 24
Most likely caused by rolling in this change: https://skia-review.googlesource.com/c/skia/+/156243
,
Sep 24
Suspecting Skia roll caused bot compile failure: https://chromium-review.googlesource.com/c/chromium/src/+/1239654
,
Sep 24
I changed my args.gn to "is_component_buid = false" and it built.
,
Sep 24
I think it's https://skia-review.googlesource.com/c/skia/+/156245. I'll revert that now. When it rolls in, it should add SK_API back to SkColor4f::FromColor (a.k.a. SkRGBA4f<(SkAlphaType)3>::FromColor)
,
Sep 24
,
Sep 24
,
Sep 24
Looks like the fix is in with this Skia roll: https://chromium-review.googlesource.com/c/chromium/src/+/1240076
,
Sep 24
Just synced and built chrome & browser_tests. No problem.
,
Sep 24
The following revision refers to this bug: https://skia.googlesource.com/buildbot/+/e91c4a3856a00acda2718a0f79443707ac7e3a07 commit e91c4a3856a00acda2718a0f79443707ac7e3a07 Author: Mike Klein <mtklein@google.com> Date: Mon Sep 24 14:42:35 2018 add linux-chromeos-compile-dbg to Skia->Chrome roll This should prevent this sort of failure from sneaking through: https://skia-review.googlesource.com/c/skia/+/156246/2 like it did here, https://chromium-review.googlesource.com/c/chromium/src/+/1239654/2 Bug: chromium:888381 , skia:8406 Change-Id: I121e9d284d4891c288e97ad63e0813de9ba56c1e Reviewed-on: https://skia-review.googlesource.com/156247 Auto-Submit: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com> [modify] https://crrev.com/e91c4a3856a00acda2718a0f79443707ac7e3a07/autoroll/config/skia-chromium.json
,
Sep 24
The following revision refers to this bug: https://skia.googlesource.com/skia/+/f6a4bd87178c39a5e4b968aa42f39610574c5979 commit f6a4bd87178c39a5e4b968aa42f39610574c5979 Author: Mike Klein <mtklein@google.com> Date: Mon Sep 24 15:43:10 2018 Reland "focus exported color apis" This is a reland of c5de102ff4b86b2f0facc011c1f47daa0fa68e97 This time around, SkColor4f::FromColor() is also exported, as it is used by Chrome OS. Original change's description: > focus exported color apis > > Change-Id: I97f9db61698b6fee783fa3d6bfbbdd023fd6fee5 > Reviewed-on: https://skia-review.googlesource.com/156245 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> Bug: chromium:888381 Cq-Include-Trybots: luci.chromium.try:linux-chromeos-compile-dbg Change-Id: I616e28ab7262bdce1c80a027a898119f4ff0eee3 Reviewed-on: https://skia-review.googlesource.com/156246 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com> [modify] https://crrev.com/f6a4bd87178c39a5e4b968aa42f39610574c5979/src/core/SkColor.cpp [modify] https://crrev.com/f6a4bd87178c39a5e4b968aa42f39610574c5979/include/core/SkColor.h
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fa3487243094032e55a6a2a1b5923d46986c433 commit 2fa3487243094032e55a6a2a1b5923d46986c433 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Sep 24 17:43:41 2018 Roll src/third_party/skia a9adb6f03525..4fb073ac7328 (4 commits) https://skia.googlesource.com/skia.git/+log/a9adb6f03525..4fb073ac7328 git log a9adb6f03525..4fb073ac7328 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 mtklein@google.com use __builtin_debugtrap() in sk_abort_no_print() where possible 2018-09-24 mtklein@google.com make only valid SkRRects in FuzzPath 2018-09-24 kjlubick@google.com Remove coverage bots 2018-09-24 mtklein@google.com Reland "focus exported color apis" Created with: gclient setdep -r src/third_party/skia@4fb073ac7328 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG= chromium:888381 TBR=bsalomon@chromium.org Change-Id: I9f3de224dfaf69b7693e936acd43d9f192a44ff3 Reviewed-on: https://chromium-review.googlesource.com/1240476 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593587} [modify] https://crrev.com/2fa3487243094032e55a6a2a1b5923d46986c433/DEPS |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by lucmult@chromium.org
, Sep 24