Issues with "messages from Google" at bottom of New Tab Page
Reported by
fadil.no...@gmail.com,
Sep 23
|
||||
Issue descriptionChrome Version : 69.0.3497.100 OS Version: 10.0 --- Issue 1: NTP message doesn't show on lower-res screens unless zoom is reduced --- What steps will reproduce the problem? 1. Open the New Tab Page on a lower-res screen (e.g. 1366 x 768) at default 100% zoom. What is the expected result? On a day that Google displays messages on google.com (e.g. https://i.imgur.com/FBKaT9t.png), the message should be replicated on the New Tab Page. What happens instead of that? The message does not appear at the bottom of the screen: https://i.imgur.com/Zt3WZKB.png Please provide any additional information below. Attach a screenshot if possible. If zoom is reduced (e.g. to 90% on a 1366x768 monitor) then the Google message reappears: https://i.imgur.com/7HAE2Kz.png --- Issue 2 : NTP message hyperlinks do not have a good default colour when themes are set --- What steps will reproduce the problem? 1. Install a basic theme that does not override theme/colors/ntp_text . Chrome Basic Theme (https://chrome.google.com/webstore/detail/chrome-basic-theme/bkfgkhbmafjhnmdkpgpnoalibenejpfc?hl=en) will work for this purpose. 2. Go to the New Tab Page on a day that Google sets messages on google.com. What is the expected result? When the Google message has a hyperlink, the colour of the hyperlink should be a colour that is distinguishable from the rest of the text. Here is the default without a theme - the colour of the hyperlink is blue (#1a0dab): https://i.imgur.com/jnF3jWY.png What happens instead of that? The hyperlink colour is almost exactly the same colour as the surrounding text: https://i.imgur.com/aziLpkb.png . Hyperlink and surrounding text are indistiguisable. --- UserAgentString: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36
,
Sep 24
,
Sep 24
Thanks for filing both of these. 1. This allows the icons to remain clickable without the promo obscuring them, and without introducing a scrollbar on the NTP on low res screens (*). The promo is visible upon zoom or window resizing (on higher res screens). +Yana: it seems like the scrollbar is a necessary trade-off here? 2. This is a known issue that Kristi's currently working on. Both are remote NTP only, and might be addressable in the M69/M70 timeframe. (*) Note that messaging UI toasts temporarily obscure the icons, but are short-lived.
,
Sep 25
For 1, I'm pretty sure we purposefully don't introduce the scrollbar in this case to avoid scrolling on small-res devices such as the Pixelbook when the promo appears.
,
Sep 25
Yes, that was the reasoning for small-res devices. Without auto-hide on Pixelbook, the promo would be visible, but obscure custom links for the life of the promo. With auto-hide, the user never sees the promo on Pixelbook, unless they zoom out.
,
Sep 25
Given that promos are less valuable to the user and that we don't won't scrolling behavior, let's close this as won't fix.
,
Sep 25
,
Sep 25
👍🏼👍🏼
,
Sep 26
With number 1, this is understandable (though slightly disappointing). --- With number 2, it's just come to my attention that theme/colors/ntp_text is responsible not only for the promo hyperlinks, but also for the text colour on the chrome://apps page. I am the author of a dark theme, and currently I have set theme/colors/ntp_text to 255,255,255 because my ntp_background is a dark colour. This means that the chrome://apps text is white (https://i.imgur.com/WHfBlth.png) but the promo text is also white and unreadable (https://i.imgur.com/NFaViQc.png). Now, if I set theme/colors/ntp_text to 0,0,0; then I have the opposite problem but in reverse. I can see the promo text (https://i.imgur.com/aEmgPkl.png) but now the chrome://apps text is unreadable (https://i.imgur.com/fmY05Fq.png). Can you confirm that, when you fix the promo hyperlink issue, this issue will also be fixed? I want to set a different colour for the apps text and the promo hyperlink but I can't because the two things are tied together in Chrome.
,
Sep 26
c9: Yes the promo link color has been fixed (still in the process of rolling out), with the caveat that it will always be set to blue (#3367D6).
,
Sep 26
Awesome - thanks for your quick response. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vamshi.kommuri@chromium.org
, Sep 23