New issue
Advanced search Search tips

Issue 888308 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Flaky-Test: ChromeRenderProcessHostBackgroundingTest.MultipleTabs



Sign in to add a comment

ChromeRenderProcessHostBackgroundingTest.MultipleTabs is flaky

Project Member Reported by Findit, Sep 23

Issue description


Flaky test: ChromeRenderProcessHostBackgroundingTest.MultipleTabs
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=401d81773ce32510
Test output log: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/15414
Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/If88a8dd13b9b7b0500d08a180658597ae6f5997d
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLm1hYy9NYWMxMC4xMiBUZXN0cy8xNTQxNC9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMi42L1EyaHliMjFsVW1WdVpHVnlVSEp2WTJWemMwaHZjM1JDWVdOclozSnZkVzVrYVc1blZHVnpkQzVOZFd4MGFYQnNaVlJoWW5NPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20ChromeRenderProcessHostBackgroundingTest.MultipleTabs&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLm1hYy9NYWMxMC4xMiBUZXN0cy8xNTQxNC9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMi42L1EyaHliMjFsVW1WdVpHVnlVSEp2WTJWemMwaHZjM1JDWVdOclozSnZkVzVrYVc1blZHVnpkQzVOZFd4MGFYQnNaVlJoWW5NPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
 
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
rsesek@ this points to your crrev.com/c/1198306 which sounds broader than the test failure. Can you see if you can make any sense of it?

../../chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc:379: Failure
Value of: process3.IsProcessBackgrounded(port_provider)
  Actual: false
Expected: true
Stack trace:
0   browser_tests                       0x000000010fa923db testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   browser_tests                       0x000000010fa91da9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   browser_tests                       0x000000010ea80c02 ChromeRenderProcessHostBackgroundingTest_MultipleTabs_Test::RunTestOnMainThread() + 3346
3   browser_tests                       0x0000000112220beb content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
4   browser_tests                       0x0000000111cdf647 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4375
5   browser_tests                       0x0000000111cde42e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
6   browser_tests                       0x0000000110745de3 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
7   browser_tests                       0x0000000110b5ad97 content::StartupTaskRunner::RunAllTasksNow() + 39
8   browser_tests                       0x0000000110744538 content::BrowserMainLoop::CreateStartupTasks() + 712
9   browser_tests                       0x0000000110748300 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96
10  browser_tests                       0x0000000110742654 content::BrowserMain(content::MainFunctionParams const&) + 180
11  browser_tests                       0x0000000111b0eef2 content::ContentMainRunnerImpl::Run(bool) + 610
12  browser_tests                       0x0000000113bfa111 service_manager::Main(service_manager::MainParams const&) + 2849
13  browser_tests                       0x0000000111b0e0e4 content::ContentMain(content::ContentMainParams const&) + 68
14  browser_tests                       0x0000000112220819 content::BrowserTestBase::SetUp() + 2697
15  browser_tests                       0x0000000111c67b75 InProcessBrowserTest::SetUp() + 517
Yeah, that was a pretty broad change so I'm a little skeptical. Looking at https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeRenderProcessHostBackgroundingTest.MultipleTabs it seems like this test has been flaking for quite a while. My CL landed on Sept. 23, but I see flakes before that.

Will see if I can look into the cause a little more tomorrow.
Labels: -Sheriff-Chromium
Labels: Sheriff-Chromium
Sorry misread these[1] instructions, first time sheriff here, re-adding the Sheriff-Chromium label .

[1] http://dev.chromium.org/developers/tree-sheriffs/sheriffing-bug-queues
Labels: -Sheriff-Chromium
disabling: https://chromium-review.googlesource.com/c/chromium/src/+/1246829
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c00db861aebca3b14ab27a41c7425bedcbd81ae4

commit c00db861aebca3b14ab27a41c7425bedcbd81ae4
Author: Evan Stade <estade@chromium.org>
Date: Wed Sep 26 20:00:19 2018

Disable ChromeRenderProcessHostBackgroundingTest.MultipleTabs on Mac

it's flaky.

TBR=rsesek@chromium.org

Bug: 888308
Change-Id: If250e1233fe58cc699358e879cbedc2ff797760c
Reviewed-on: https://chromium-review.googlesource.com/1246829
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594445}
[modify] https://crrev.com/c00db861aebca3b14ab27a41c7425bedcbd81ae4/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Cc: rsesek@chromium.org
Components: Tests>Flaky
Labels: OS-Mac
Owner: gab@chromium.org
This maybe started around the time that https://chromium.googlesource.com/chromium/src/+/c492203d118a287fa628c074e59acc7989996832 landed ?

Sign in to add a comment