New issue
Advanced search Search tips

Issue 888270 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[LayoutNG] Enable LayoutNG flag breaks Chrome's UI

Reported by michel.b...@gmail.com, Sep 22

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3554.0 Safari/537.36

Steps to reproduce the problem:
1. Enable chrome://flags/#enable-layout-ng
2. Restart browser
3. Open chrome://settings/clearBrowserData

What is the expected behavior?
Clear browsing data balloon will be in the middle of the screen.

What went wrong?
Clear browsing data balloon is shifted down, to the bottom and is not completely visible.

If I disable this flag, everything is OK.

Did this work before? Yes 

Chrome version: 71.0.3554.0  Channel: dev
OS Version: 10.0
Flash Version: 

Google Chrome	71.0.3554.0 (Official Build) dev (64-bit) (cohort: Dev)
Revision	50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1}
OS	Windows
JavaScript	V8 7.1.113
Flash	31.0.0.118 C:\Users\User\AppData\Local\Google\Chrome Dev\User Data\PepperFlash\31.0.0.118\pepflashplayer.dll
User Agent	Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3554.0 Safari/537.36
Command Line	"C:\Program Files (x86)\Google\Chrome Dev\Application\chrome.exe" --flag-switches-begin --enable-features=LayoutNG --flag-switches-end
 
22_193511.png
42.6 KB View Download
Labels: Needs-Bisect Needs-Triage-M71
Cc: vamshi.kommuri@chromium.org
Components: -UI UI>Settings
Labels: -Needs-Bisect -Type-Bug-Regression Triaged-ET Target-71 M-71 FoundIn-71 OS-Linux OS-Mac Type-Bug
Status: Untriaged (was: Unconfirmed)
Thanks for filing the issue!

Able to reproduce the issue on reported chrome version 71.0.3554.0 and on the latest canary 71.0.3559.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1

Flag, #enable-layout-ng is introduced in version 69.0.3482.0 and the issue is seen in this version too. Hence considering it as Non-Regression and marking it as Untriaged. Removing Needs-Bisect label and requesting someone from respective team to have a look into this and help in further triaging it.
Components: Blink>Layout
Summary: [LayoutNG] Enable LayoutNG flag breaks Chrome's UI (was: Enable LayoutNG flag breaks Chrome's UI)
This basically happens with any cr-dialog within Settings or Extensions, not just clear browsing data dialog.

Suspecting that this is related to the underlying <dialog> element positioning.
Owner: mstensho@chromium.org
Status: Assigned (was: Untriaged)
Yes, we fail to position the DIALOG element. It has non-auto top/bottom (50%/50%), so we refrain from applying any DIALOG magic to it. We fall back to generic out-of-flow positioning. Here we consider the element to be over-constrained, so we disregard bottom:50%. But we're not really over-constrained, because margins are auto, so the right thing to do, would have been to resolve those, rather than disregarding the bottom property.
tc.html
276 bytes View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67ef0616d0d14b2e8931459d0a93cbcd63b03843

commit 67ef0616d0d14b2e8931459d0a93cbcd63b03843
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Oct 09 19:58:03 2018

[LayoutNG] Auto top/bottom margins may resolve to negative values.

The spec doesn't say that auto margin-top or margin-bottom need to
resolve to something non-negative, so just allow negative values as
well. They don't cause over-constrainedness.

Also, when distributing the space to margin-top and margin-bottom, make
sure that everything gets distributed. Set margin-top to the half, and
set margin-bottom to total space MINUS margin-top. Just dividing both by
two might cause us to lose a tiny fraction of the total, due to rounding.

Bug:  888270 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia10577851e60707a0e2d67857a1c43a12e28b9d2
Reviewed-on: https://chromium-review.googlesource.com/c/1269855
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598052}
[add] https://crrev.com/67ef0616d0d14b2e8931459d0a93cbcd63b03843/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/absolute-non-replaced-height-013.html
[modify] https://crrev.com/67ef0616d0d14b2e8931459d0a93cbcd63b03843/third_party/blink/renderer/core/layout/ng/ng_absolute_utils.cc
[modify] https://crrev.com/67ef0616d0d14b2e8931459d0a93cbcd63b03843/third_party/blink/renderer/core/layout/ng/ng_absolute_utils_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment