New issue
Advanced search Search tips

Issue 888233 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in SkTInternalLList<TriangulationVertex>::addToTail

Project Member Reported by ClusterFuzz, Sep 22

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5335273658122240

Fuzzer: libFuzzer_skia_image_filter_proto_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  SkTInternalLList<TriangulationVertex>::addToTail
  ReflexHash::add
  SkTriangulateSimplePolygon
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=593403:593413

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5335273658122240

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 22

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 22

Labels: Test-Predator-Auto-Owner
Owner: jvanverth@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/9b2182551fa22a7321330627d647431ec089e060 (Optimize SkTriangulateSimplePolygon.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
 Issue oss-fuzz:10619  has been merged into this issue.
 Issue oss-fuzz:10623  has been merged into this issue.
Cc: jvanverth@google.com
 Issue 888234  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ac9f090976d80790cc601a6d76b0dc29ca14f500

commit ac9f090976d80790cc601a6d76b0dc29ca14f500
Author: Jim Van Verth <jvanverth@google.com>
Date: Mon Sep 24 16:51:18 2018

Make sure ReflexHash grid count is reasonable

Bug:  chromium:888233 
Change-Id: I42bea81d8dc6eee3516ed585f8bb838ef20ce554
Reviewed-on: https://skia-review.googlesource.com/156368
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/ac9f090976d80790cc601a6d76b0dc29ca14f500/src/utils/SkPolyUtils.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f477d2720e776e087f8b753419665a94a8ff65dd

commit f477d2720e776e087f8b753419665a94a8ff65dd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Sep 24 21:05:26 2018

Roll src/third_party/skia 4fb073ac7328..9461dcf1306a (7 commits)

https://skia.googlesource.com/skia.git/+log/4fb073ac7328..9461dcf1306a


git log 4fb073ac7328..9461dcf1306a --date=short --no-merges --format='%ad %ae %s'
2018-09-24 michaelludwig@google.com Revert "Implement an explicit binary search-based analytic gradient colorizer"
2018-09-24 fmalita@chromium.org [skottie] Initial property setters
2018-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b9dc92669da2..82ea7fbce65f (1 commits)
2018-09-24 fmalita@chromium.org UBSAN: Divide-by-zero in SkRRect::setRectXY
2018-09-24 halcanary@google.com SkPDF: simplify SkPDFDevice::drawPaint.
2018-09-24 jvanverth@google.com Make sure ReflexHash grid count is reasonable
2018-09-24 michaelludwig@google.com Implement an explicit binary search-based analytic gradient colorizer


Created with:
  gclient setdep -r src/third_party/skia@9461dcf1306a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG= chromium:796479 , chromium:729727 , chromium:696603 , chromium:543625 , chromium:414254 , chromium:888233 , chromium:796479 , chromium:729727 , chromium:696603 , chromium:543625 , chromium:414254 
TBR=bsalomon@chromium.org

Change-Id: I5c06466571c0dbc74c36d61f4a9c7a6552f75eee
Reviewed-on: https://chromium-review.googlesource.com/1240836
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593675}
[modify] https://crrev.com/f477d2720e776e087f8b753419665a94a8ff65dd/DEPS

Project Member

Comment 9 by ClusterFuzz, Sep 25

ClusterFuzz has detected this issue as fixed in range 593673:593695.

Detailed report: https://clusterfuzz.com/testcase?key=5335273658122240

Fuzzer: libFuzzer_skia_image_filter_proto_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  SkTInternalLList<TriangulationVertex>::addToTail
  ReflexHash::add
  SkTriangulateSimplePolygon
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=593403:593413
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=593673:593695

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5335273658122240

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Sep 25

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5335273658122240 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment