Shelf corners look funny if background changes before animation finishes. |
|||||||
Issue description(1) On home launcher. (2) Tap any shelf button and tap launcher in quick succession. What is the expected result? Rounded corners on the top of shelf. What happens instead? One corner is not rounded, sometimes an artifact shows up.
,
Oct 15
,
Oct 19
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e Author: Manu Cornet <manucornet@chromium.org> Date: Wed Oct 24 01:07:06 2018 CrOS shelf: use translation for auto-hide instead of altering size Bug: 891416 , 886622 , 888205 , 887733 ,881684,822477 Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4 Reviewed-on: https://chromium-review.googlesource.com/c/1290056 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602201} [modify] https://crrev.com/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e/ash/shelf/shelf_constants.h [modify] https://crrev.com/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e/ash/shelf/shelf_widget.cc [modify] https://crrev.com/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e/ash/wm/pip/pip_positioner_unittest.cc
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8 Commit: 62dcf48b9ecd4ac3b24667a133b7c373cc296bb8 Author: manucornet@chromium.org Commiter: manucornet@chromium.org Date: 2018-10-25 09:41:55 +0000 UTC CrOS shelf: use translation for auto-hide instead of altering size TBR=manucornet@chromium.org (cherry picked from commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e) Bug: 891416 , 886622 , 888205 , 887733 ,881684,822477 Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4 Reviewed-on: https://chromium-review.googlesource.com/c/1290056 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602201} Reviewed-on: https://chromium-review.googlesource.com/c/1298945 Reviewed-by: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#314} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8 commit 62dcf48b9ecd4ac3b24667a133b7c373cc296bb8 Author: Manu Cornet <manucornet@chromium.org> Date: Thu Oct 25 09:41:55 2018 CrOS shelf: use translation for auto-hide instead of altering size TBR=manucornet@chromium.org (cherry picked from commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e) Bug: 891416 , 886622 , 888205 , 887733 ,881684,822477 Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4 Reviewed-on: https://chromium-review.googlesource.com/c/1290056 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602201} Reviewed-on: https://chromium-review.googlesource.com/c/1298945 Reviewed-by: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#314} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_constants.h [modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_widget.cc [modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/system/toast/toast_manager_unittest.cc
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 18
The animation changes above have potentially fixed this bug. I still need to double check.
,
Dec 21
Ok I haven't been able to reproduce this. Please feel free to reopen if you still see this. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by newcomer@chromium.org
, Oct 15