Create FaviconLoader Unittests |
||||||
Issue descriptionCurrently FaviconLoader is lacking unittests. Since it is going to be the go-to favicon retrieval service for the Bling UI, it is more important to have tests. Model it off of the deleted FaviconViewProvider Unittests.
,
Sep 26
,
Sep 27
,
Sep 28
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa69dfc84ea90d9f9992e3d9728cf6c3d53de08e commit fa69dfc84ea90d9f9992e3d9728cf6c3d53de08e Author: Chris Lu <thegreenfrog@chromium.org> Date: Thu Nov 15 21:47:59 2018 [ios] Create FaviconLoader Unittests Bug: 888198 Change-Id: Iefbb8ce1c55480697eaab072f3c408cb1d14f852 Reviewed-on: https://chromium-review.googlesource.com/c/1269945 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#608527} [modify] https://crrev.com/fa69dfc84ea90d9f9992e3d9728cf6c3d53de08e/ios/chrome/browser/favicon/BUILD.gn [modify] https://crrev.com/fa69dfc84ea90d9f9992e3d9728cf6c3d53de08e/ios/chrome/browser/favicon/favicon_loader.mm [add] https://crrev.com/fa69dfc84ea90d9f9992e3d9728cf6c3d53de08e/ios/chrome/browser/favicon/favicon_loader_unittest.mm
,
Nov 16
,
Nov 19
** Mass UI Triage ** Since fix is landed, Closing this issue. If this bug still reproduces for you, please reopen or file a new issue. Thanks! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by thegreenfrog@chromium.org
, Sep 22