Issue metadata
Sign in to add a comment
|
ChromeSessionManagerTest.LoginExistingUsers is flaky on single process mash browser_tests |
||||||||||||||||||||||||
Issue descriptionChromeSessionManagerTest.LoginExistingUsers is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTQsSBUZsYWtlIkJjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZVNlc3Npb25NYW5hZ2VyVGVzdC5Mb2dpbkV4aXN0aW5nVXNlcnMM. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20ChromeSessionManagerTest.LoginExistingUsers&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTQsSBUZsYWtlIkJjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENocm9tZVNlc3Npb25NYW5hZ2VyVGVzdC5Mb2dpbkV4aXN0aW5nVXNlcnMM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Sep 26
Xiyuan, please have a look to see if the flake is actionable or help assign to a more suitable owner. Removing sheriff label for now as the flake recovered.
,
Sep 26
rcui@, could you update the filter to disable it for now? ==== [10969:10969:0924/083102.275291:FATAL:focus_controller.cc(238)] Check failed: rules_->CanFocusWindow(window, nullptr). #0 0x000004f76d3c base::debug::StackTrace::StackTrace() #1 0x000004edcacb logging::LogMessage::~LogMessage() #2 0x00000a9682e5 wm::FocusController::SetFocusedWindow() #3 0x00000a96876f wm::FocusController::ResetFocusWithinActiveWindow() #4 0x0000080419f7 ws::FocusHandler::SetFocus() #5 0x000008036555 ws::WindowTree::SetFocusImpl() #6 0x00000803a57f ws::WindowTree::SetFocus() #7 0x000003170837 ws::mojom::WindowTreeStubDispatch::Accept() #8 0x000005eca866 mojo::InterfaceEndpointClient::HandleValidatedMessage() #9 0x000005edb6e6 mojo::FilterChain::Accept() #10 0x000005ecbbf5 mojo::InterfaceEndpointClient::HandleIncomingMessage() #11 0x000005ed166b mojo::internal::MultiplexRouter::ProcessIncomingMessage() #12 0x000005ed0a90 mojo::internal::MultiplexRouter::Accept() #13 0x000005edb6e6 mojo::FilterChain::Accept() #14 0x000005ec86f4 mojo::Connector::ReadSingleMessage() #15 0x000005ec9151 mojo::Connector::ReadAllAvailableMessages() #16 0x000005ec8ff9 mojo::Connector::OnHandleReadyInternal() #17 0x000002fece97 mojo::SimpleWatcher::DiscardReadyState() #18 0x000005602ef4 mojo::SimpleWatcher::OnHandleReady() #19 0x000003221ae1 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz14GpuServiceImplEFvN3gfx21GenericSharedMemoryIdEiRKN3gpu9SyncTokenEEJNS_7WeakPtrIS4_EES6_iS8_EEEFvvEE7RunImplISC_NSt3__15tupleIJSE_S6_iS8_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE #20 0x000004f9a465 base::debug::TaskAnnotator::RunTask() #21 0x000004ee4ede base::MessageLoop::RunTask() #22 0x000004ee5263 base::MessageLoop::DoWork() #23 0x000004f94f89 base::MessagePumpLibevent::Run() #24 0x000004ee4a74 base::MessageLoop::Run() #25 0x000004f0d279 base::RunLoop::Run() #26 0x000004f0d7fa base::RunLoop::RunUntilIdle() #27 0x000001bac2af chromeos::ChromeSessionManagerTest_LoginExistingUsers_Test::RunTestOnMainThread()
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b55b441b3a73ddc89a66a7f6bdaf6049cc89dfe commit 5b55b441b3a73ddc89a66a7f6bdaf6049cc89dfe Author: Ryan Cui <rcui@chromium.org> Date: Thu Sep 27 20:36:42 2018 Disable flaky chrome session manager login tests Bug: 888188 Change-Id: I9056c918ceda50d5c50d7dfbadef5c22f7e80d34 Reviewed-on: https://chromium-review.googlesource.com/1246948 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#594842} [modify] https://crrev.com/5b55b441b3a73ddc89a66a7f6bdaf6049cc89dfe/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Oct 3
,
Oct 3
,
Nov 6
,
Nov 7
The problem with issue 859257 is that SetFocusedWindow is not called (because the browser window is not visible at the time the page focus is set). The problem here is that it is called for a wrong window. I will take a closer look.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea96fc423e39714471c2277d4eee91fa9494571d commit ea96fc423e39714471c2277d4eee91fa9494571d Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Nov 08 22:55:32 2018 Enable LoginExistingUsers test for mash Suspect http://crrev.com/c/1259296 fixed it. Bug: 888188 Change-Id: I40d9246fa5ad777cb91fd5aa9e740c1c550643bf Reviewed-on: https://chromium-review.googlesource.com/c/1327552 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606635} [modify] https://crrev.com/ea96fc423e39714471c2277d4eee91fa9494571d/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Nov 8
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 24