New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 888176 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 867488



Sign in to add a comment

Implement NTP tiles for Explore Sites

Project Member Reported by dewittj@chromium.org, Sep 21

Issue description

This bug tracks the work for ExploreSites which is targeted for M71, we need to keep the experimental one around for the October experiment, but want to land the for-real category tiles based on the mocks.

The existing tiles infra is too complex for what we need, it doesn't make sense to integrate more deeply into that system at this time.
 
The steps will be as follows:
* Alter the ViewStub in new_tab_page_layout.xml to remove references to experimental version, make its default the real layout.
* Alter NewTabPageLayout.java to update the layout of the ExploreSites ViewStub to the experimental version if the right finch variation is enabled.  This will allow the experimental version to continue to exist.
* Add a new ExploreSitesSection that manages image loading and tile inflation for the new section, very similar to ExperimentalExploreSitesSection.

Theresa, I will update here with the design as I flesh out more details, please feel free to comment if you see something here that doesn't match your idea of how we might do this.
 
That plan sounds good to me.
Labels: -Type-Bug Type-Task
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3

commit 51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3
Author: Justin DeWitt <dewittj@chromium.org>
Date: Tue Sep 25 17:19:07 2018

[EoS] Adds the NTP category tiles when the experiment is enabled.

This patch does the following:
* Adds a method to determine the variation of ExploreSites that is enabled
* Inflates the ExploreSites ViewStub with the layout appropriate for the
  variation
* Renames several dimensions to make them specific for the Experimental
  variation of EoS.
* Adds a TileGridLayout for ExploreSites to match the Suggestions
  TileGridLayout
* Adds two ExploreSitesCategory TileView classes (regular and condensed)
* Adds an ExploreSitesSection that asks for the catalog and inflates the
  category tiles.

This does not properly hook up:
* Icon generation/fetching
* exact layout parameters.

Bug:  888176 

Change-Id: Ie7e1b9f66defeac745dce98853e06f10af88330a
Reviewed-on: https://chromium-review.googlesource.com/1239658
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593978}
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/BUILD.gn
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/experimental_explore_sites_category_tile_view.xml
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/experimental_explore_sites_section.xml
[add] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/explore_sites_category_tile_view.xml
[add] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/explore_sites_category_tile_view_condensed.xml
[add] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/explore_sites_section.xml
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/suggestions_tile_view.xml
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/layout/suggestions_tile_view_condensed.xml
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExperimentalExploreSitesCategoryTileView.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExperimentalExploreSitesSection.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java
[add] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTileView.java
[add] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesTileView.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsConfig.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsTileView.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileRenderer.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java/src/org/chromium/chrome/browser/widget/tile/TileWithTextView.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/java_sources.gni
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/51865f3e78c5d0b7dbbee2d563e3cb1a4d7222c3/chrome/browser/android/explore_sites/explore_sites_feature.h

Blocking: 867488
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89824093b12d691ca52349e906dd9b27567f8e8c

commit 89824093b12d691ca52349e906dd9b27567f8e8c
Author: Justin DeWitt <dewittj@chromium.org>
Date: Wed Sep 26 19:17:58 2018

[EoS] Adds support for default category icons.

This adds the Material icons we intend to use if
the categories are not yet available - mostly if
the user is offline during the First Run experience,
or if the sqlite DB got corrupted for some reason.

Bug:  888176 
Change-Id: I2dcc31ae2b5afbe55561a389296239ba4c566a1c
Reviewed-on: https://chromium-review.googlesource.com/1244737
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594421}
[add] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/res/drawable/ic_arrow_forward_blue_24dp.xml
[add] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/res/drawable/ic_directions_run_blue_24dp.xml
[add] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/res/drawable/ic_restaurant_menu_blue_24dp.xml
[add] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/res/drawable/ic_shopping_basket_blue_24dp.xml
[modify] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java
[modify] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTileView.java
[modify] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/strings/android_chrome_strings_grd/IDS_EXPLORE_SITES_DEFAULT_CATEGORY_COOKING.png.sha1
[add] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/strings/android_chrome_strings_grd/IDS_EXPLORE_SITES_DEFAULT_CATEGORY_SHOPPING.png.sha1
[add] https://crrev.com/89824093b12d691ca52349e906dd9b27567f8e8c/chrome/android/java/strings/android_chrome_strings_grd/IDS_EXPLORE_SITES_DEFAULT_CATEGORY_SPORTS.png.sha1

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11

Status: Fixed (was: Assigned)

Sign in to add a comment