Can still see home launcher and windows animation in tabs drag |
|||||
Issue descriptionChrome Version: 71.0.3559.0 What steps will reproduce the problem? (1) Drag one tab from multiple tabs further enough to shrink the source window. What is the expected result? Should have no home launcher or windows animation behind. What happens instead? Can still see the home launcher animation and windows animation behind.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2 commit c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2 Author: Xiaoqian Dai <xdai@chromium.org> Date: Wed Oct 17 21:12:23 2018 Disable the home launcher animation when tab-dragging starts/ends. Also disable other windows hide/show animation when tab-dragging process starts/ends. Bug: 888173 Change-Id: Iee22d20832cefd61ad7ebdea30b5a65e75b9f204 Reviewed-on: https://chromium-review.googlesource.com/c/1282162 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600552} [modify] https://crrev.com/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2/ash/BUILD.gn [modify] https://crrev.com/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2/ash/app_list/app_list_controller_impl.h [modify] https://crrev.com/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2/ash/app_list/home_launcher_gesture_handler.cc [add] https://crrev.com/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2/ash/scoped_animation_disabler.cc [add] https://crrev.com/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2/ash/scoped_animation_disabler.h [modify] https://crrev.com/c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2/ash/wm/tablet_mode/tablet_mode_browser_window_drag_delegate.cc
,
Oct 17
Disabling the animation can improve the smoothness of tab-dragging. Thus request merge back.
,
Oct 18
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61729e4783b846d2ae6fb4b7007cd0cd20a762d3 commit 61729e4783b846d2ae6fb4b7007cd0cd20a762d3 Author: Xiaoqian Dai <xdai@chromium.org> Date: Fri Oct 19 04:39:26 2018 [Merge to M71] Disable the home launcher animation when tab-dragging starts/ends. Also disable other windows hide/show animation when tab-dragging process starts/ends. Bug: 888173 TBR=xiyuan@chromium.org Change-Id: Iee22d20832cefd61ad7ebdea30b5a65e75b9f204 Reviewed-on: https://chromium-review.googlesource.com/c/1282162 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600552}(cherry picked from commit c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2) Reviewed-on: https://chromium-review.googlesource.com/c/1290517 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#149} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/61729e4783b846d2ae6fb4b7007cd0cd20a762d3/ash/BUILD.gn [modify] https://crrev.com/61729e4783b846d2ae6fb4b7007cd0cd20a762d3/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/61729e4783b846d2ae6fb4b7007cd0cd20a762d3/ash/app_list/app_list_controller_impl.h [modify] https://crrev.com/61729e4783b846d2ae6fb4b7007cd0cd20a762d3/ash/app_list/home_launcher_gesture_handler.cc [add] https://crrev.com/61729e4783b846d2ae6fb4b7007cd0cd20a762d3/ash/scoped_animation_disabler.cc [add] https://crrev.com/61729e4783b846d2ae6fb4b7007cd0cd20a762d3/ash/scoped_animation_disabler.h [modify] https://crrev.com/61729e4783b846d2ae6fb4b7007cd0cd20a762d3/ash/wm/tablet_mode/tablet_mode_browser_window_drag_delegate.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61729e4783b846d2ae6fb4b7007cd0cd20a762d3 Commit: 61729e4783b846d2ae6fb4b7007cd0cd20a762d3 Author: xdai@chromium.org Commiter: xdai@chromium.org Date: 2018-10-19 04:39:26 +0000 UTC [Merge to M71] Disable the home launcher animation when tab-dragging starts/ends. Also disable other windows hide/show animation when tab-dragging process starts/ends. Bug: 888173 TBR=xiyuan@chromium.org Change-Id: Iee22d20832cefd61ad7ebdea30b5a65e75b9f204 Reviewed-on: https://chromium-review.googlesource.com/c/1282162 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600552}(cherry picked from commit c1544b3d38b770c8b53e4f2a4ca52cb388ef39b2) Reviewed-on: https://chromium-review.googlesource.com/c/1290517 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#149} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by weifangsun@chromium.org
, Sep 28