New issue
Advanced search Search tips

Issue 888164 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

bug in "cros_workon info" output for linux kernel packages

Project Member Reported by zwisler@chromium.org, Sep 21

Issue description

Chrome Version: (copy from chrome://version)

N/A

OS: (e.g. Win10, MacOS 10.12, etc...)

Building in Linux.

What steps will reproduce the problem?

$ cros_workon --all info | grep sys-kernel
sys-kernel/chromeos-kernel-3_10 chromiumos/third_party/kernel src/third_party/kernel/v4.4
sys-kernel/chromeos-kernel-3_14 chromiumos/third_party/kernel src/third_party/kernel/v4.4
sys-kernel/chromeos-kernel-3_18 chromiumos/third_party/kernel src/third_party/kernel/v4.4
sys-kernel/chromeos-kernel-3_8 chromiumos/third_party/kernel src/third_party/kernel/v4.4
sys-kernel/chromeos-kernel-4_14 chromiumos/third_party/kernel src/third_party/kernel/v4.4
sys-kernel/chromeos-kernel-4_4 chromiumos/third_party/kernel src/third_party/kernel/v4.4
sys-kernel/chromeos-kernel-experimental chromiumos/third_party/kernel src/third_party/kernel/v4.4

Note that the src_dir for each of the above repos is given as src/third_party/kernel/v4.4, which is wrong.

What is the expected result?

The src_dir of each kernel package should be:

$ cros_workon --all info | grep sys-kernel
sys-kernel/chromeos-kernel-3_10 chromiumos/third_party/kernel src/third_party/kernel/v3.10
sys-kernel/chromeos-kernel-3_14 chromiumos/third_party/kernel src/third_party/kernel/v3.14
sys-kernel/chromeos-kernel-3_18 chromiumos/third_party/kernel src/third_party/kernel/v3.18
sys-kernel/chromeos-kernel-3_8 chromiumos/third_party/kernel src/third_party/kernel/v3.8
sys-kernel/chromeos-kernel-4_14 chromiumos/third_party/kernel src/third_party/kernel/v4.14
sys-kernel/chromeos-kernel-4_4 chromiumos/third_party/kernel src/third_party/kernel/v4.4
sys-kernel/chromeos-kernel-experimental chromiumos/third_party/kernel src/third_party/kernel/experimental

Please use labels and text to provide additional information.

I looked at this a little, and this is happening because the code in WorkonHelper::GetPackageInfo() in lib/workon_helper.py assumes that there is a 1:1 relationship between the the repo and src_path, and that you can use the repo to look up the src_path.  This 1:1 mapping from repo=>src_path may hold for other packages, but for the kernel this breaks down.
 
Owner: zwisler@google.com

Comment 2 Deleted

Sign in to add a comment