CTS: Add field trial testing config for runtime host permissions. |
|||
Issue descriptionAdd field trial testing config for runtime host permissions experiment. This is a prerequisite to enable the experiment for beta/stable channel.
,
Sep 22
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da05d4bb9604b81fa23a30858f04b70abd6be1d3 commit da05d4bb9604b81fa23a30858f04b70abd6be1d3 Author: Karan Bhatia <karandeepb@chromium.org> Date: Mon Sep 24 21:29:55 2018 CTS: Make ExtensionAPITest.ActiveTab work with runtime host permissions enabled. Currently the ExtensionAPITest.ActiveTab fails with the RuntimeHostPermissions feature since it assumes that the active tab access grant is revoked when the page is navigated. However, with the runtime host permissions feature enabled, the active tab grant is only revoked when the page navigates to a different origin. Fix the test and also test the behavior with RuntimeHostPermissions enabled. This is in preparation of enabling RuntimeHostPermissions for field trial testing. BUG= 888158 Change-Id: I46c2c1f92d273eff80395642d0fe2733528cdf70 Reviewed-on: https://chromium-review.googlesource.com/1239210 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593691} [modify] https://crrev.com/da05d4bb9604b81fa23a30858f04b70abd6be1d3/chrome/browser/extensions/active_tab_apitest.cc [modify] https://crrev.com/da05d4bb9604b81fa23a30858f04b70abd6be1d3/chrome/test/data/extensions/api_test/active_tab/background.js
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1308b111ab0c596d40d16ce937c6f4661f37c970 commit 1308b111ab0c596d40d16ce937c6f4661f37c970 Author: Karan Bhatia <karandeepb@chromium.org> Date: Mon Sep 24 22:39:39 2018 CTS: Fix BrowserActionsBarIncognitoTest.IncognitoMode with RuntimeHostPermissions feature. Currently BrowserActionsBarIncognitoTest.IncognitoMode crashes when the RuntimeHostPermissions feature is enabled since the test calls ExtensionActionViewController::GetIcon with a null web-contents. This ends up calling ExtensionActionViewController::GetPageInteractionStatus() which accesses the null web-contents. Fix this by using InProcessBrowserTest::CreateBrowser which waits for the browser to have a valid tab. BUG= 888158 Change-Id: I7b763ff54f2a0d65e199582a9ab00549e549f8c0 Reviewed-on: https://chromium-review.googlesource.com/1239458 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593719} [modify] https://crrev.com/1308b111ab0c596d40d16ce937c6f4661f37c970/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
,
Sep 24
Fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1239204. |
|||
►
Sign in to add a comment |
|||
Comment 1 by karandeepb@chromium.org
, Sep 21