New issue
Advanced search Search tips

Issue 888155 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossFrames is flakey.

Project Member Reported by wjmaclean@chromium.org, Sep 21

Issue description

This test is flaking on a variety of bots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SitePerProcessBrowserTouchActionTest

Here are results from a particular build:

https://chromium-swarm.appspot.com/task?id=400f935166248b10&refresh=10&show_raw=1

where the log is:

[1839/2933] SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossFrames (3147 ms)
[0920/045635.524555:ERROR:kill_posix.cc(84)] Unable to terminate process group 12969: No such process (3)
[ RUN      ] SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames
Xlib:  extension "RANDR" missing on display ":99".

DevTools listening on ws://127.0.0.1:33981/devtools/browser/2d15adbc-fb64-479a-9978-b83f1c6c161c
../../content/browser/site_per_process_browsertest.cc:12470: Failure
Expected equality of these values:
  expected_touch_action
    Which is: 63
  whitelisted_touch_action.value()
    Which is: 15

Looking at 

https://cs.chromium.org/chromium/src/content/browser/site_per_process_browsertest.cc?rcl=68954ea7cf6d9a7a56e0bfa6e8417bcca3466fa5&l=12292

the returned value is probably just not available, i.e. the optional value has no value.

It seems like a bad design to use the return value from

GetEffectiveTouchActionForChild()

in an EXPECT_EQ() comparison, given that the value it returns may or may not have a meaningful value.
 
Owner: xidac...@chromium.org
Status: Assigned (was: Untriaged)
this was my change, I will take a look
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d74fd53fd00e868c019e88b0ebc775eb48499bb0

commit d74fd53fd00e868c019e88b0ebc775eb48499bb0
Author: Xida Chen <xidachen@chromium.org>
Date: Tue Oct 16 17:46:28 2018

Deflake SitePerProcessBrowserTouchActionTest

These 3 tests seem flaky. It appears that GetEffectiveTouchActionForChild
fails to update the |whitelisted_touch_action| sometimes and hence it
remains the old value.

This CL tries to deflake these tests, but resetting the
|whitelisted_touch_action| before it is used.

Bug:  888155 
Change-Id: I49a6c32adcaf1d61d314125493ccf56473f8fa30
Reviewed-on: https://chromium-review.googlesource.com/c/1278846
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600034}
[modify] https://crrev.com/d74fd53fd00e868c019e88b0ebc775eb48499bb0/content/browser/site_per_process_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment