New issue
Advanced search Search tips

Issue 888152 link

Starred by 1 user
Status: Assigned
Owner:
dtseng@chromium.org
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 888145



Sign in to add a comment

Move AutomationManagerAura into ash

Project Member Reported by jamescook@chromium.org, Sep 21 
To support mash / out-of-process ash.

High level design from meeting with dtseng:

* Ash is in charge of the desktop tree. It has an AutomationManagerAura or equivalent.
* "Remote apps" use AXRemoteHost to supply node trees to ash
* The browser is just a "remote app" like keyboard shortcut viewer
* Ash passes the node trees to the browser, which forwards them to the accessibility extension
* As a future optimization we might pass around mojo interface pointers so the remote app could talk directly to the browser, or directly to the extension

Comment 1 by jamescook@chromium.org, Sep 21

Blocking: 888145

Comment 2 by dtseng@chromium.org, Sep 25 

https://chromium-review.googlesource.com/c/chromium/src/+/1239439
should probably have referenced this bug (which was created around the same time).
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1cf45a6c67e0dbaa9312919520deff878d63a17

commit e1cf45a6c67e0dbaa9312919520deff878d63a17
Author: David Tseng <dtseng@chromium.org>
Date: Tue Sep 25 22:55:18 2018

Remove BrowserContext and Profile usage from AutomationManagerAura

Profiles are unneeded since the changes to use AutomationEventRouter. Previously, we went through the extension system's routing layer, which required a context.

Bug: 888152
Change-Id: I57260ad0507267fee94d6764464b18a141d3b09e
Reviewed-on: https://chromium-review.googlesource.com/1239265
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594136}
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/chromeos/input_method/accessibility.cc
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/e1cf45a6c67e0dbaa9312919520deff878d63a17/chrome/browser/ui/views/chrome_views_delegate.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/701b9ed02c9bec58518df5ed9442786125278438

commit 701b9ed02c9bec58518df5ed9442786125278438
Author: David Tseng <dtseng@chromium.org>
Date: Tue Dec 11 21:55:02 2018

Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate

This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura.

Highlights:
- removes usage of hard-coded desktop tree id in automation api (native and js bindings)
- makes all known tree managers implement AXHostDelegate

TBR=servolk@chromium.org

Bug: 888152
Test: existing browser_tests (Automation Api tests, ChromeVox tests).
Change-Id: I86a211d7588d280223c6dbacda0f0f1ad056a4fa
Reviewed-on: https://chromium-review.googlesource.com/c/1361650
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615677}
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/chromeos/accessibility/ax_host_service.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/chromeos/accessibility/ax_remote_host_delegate.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/common/extensions/api/automation_internal.idl
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chrome/renderer/resources/extensions/automation_custom_bindings.js
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chromecast/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chromecast/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chromecast/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chromecast/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chromecast/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chromecast/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/chromecast/renderer/extensions/automation_internal_custom_bindings.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_host_delegate.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_host_delegate.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_node_position_unittest.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_position.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_tree_id.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_tree_id.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_tree_id_registry.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/ax_tree_id_registry.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/mojom/ax_tree_id.mojom
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/mojom/ax_tree_id_mojom_traits.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/mojom/ax_tree_id_mojom_traits.h
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/accessibility/mojom/ax_tree_id_mojom_traits_unittest.cc
[modify] https://crrev.com/701b9ed02c9bec58518df5ed9442786125278438/ui/views/controls/webview/webview.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc6671812cac4dfe4c823730c911e8d6f18cba1

commit fdc6671812cac4dfe4c823730c911e8d6f18cba1
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Wed Dec 12 01:51:50 2018

Revert "Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate"

This reverts commit 701b9ed02c9bec58518df5ed9442786125278438.

Reason for revert: Seems to be causing network_service_browser_tests to fail: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17534

Original change's description:
> Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate
> 
> This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura.
> 
> Highlights:
> - removes usage of hard-coded desktop tree id in automation api (native and js bindings)
> - makes all known tree managers implement AXHostDelegate
> 
> TBR=servolk@chromium.org
> 
> Bug: 888152
> Test: existing browser_tests (Automation Api tests, ChromeVox tests).
> Change-Id: I86a211d7588d280223c6dbacda0f0f1ad056a4fa
> Reviewed-on: https://chromium-review.googlesource.com/c/1361650
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615677}

TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org

Change-Id: I8a2eedc503827eafea6f40e3b22e6ba515eaa043
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 888152
Reviewed-on: https://chromium-review.googlesource.com/c/1372991
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615774}
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/chromeos/accessibility/ax_host_service.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/chromeos/accessibility/ax_remote_host_delegate.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/common/extensions/api/automation_internal.idl
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chrome/renderer/resources/extensions/automation_custom_bindings.js
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chromecast/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chromecast/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chromecast/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chromecast/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chromecast/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chromecast/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/chromecast/renderer/extensions/automation_internal_custom_bindings.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_host_delegate.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_host_delegate.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_node_position_unittest.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_position.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_tree_id.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_tree_id.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_tree_id_registry.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/ax_tree_id_registry.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/mojom/ax_tree_id.mojom
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/mojom/ax_tree_id_mojom_traits.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/mojom/ax_tree_id_mojom_traits.h
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/accessibility/mojom/ax_tree_id_mojom_traits_unittest.cc
[modify] https://crrev.com/fdc6671812cac4dfe4c823730c911e8d6f18cba1/ui/views/controls/webview/webview.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efd9d9c7471e49e7e479310f04f53d462efedce9

commit efd9d9c7471e49e7e479310f04f53d462efedce9
Author: David Tseng <dtseng@chromium.org>
Date: Wed Dec 12 16:23:00 2018

Reland: Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate

Account for Mac codepath in AutomationInternalApi::PerformActionFunction.

Original change:
This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura.

Highlights:
- removes usage of hard-coded desktop tree id in automation api (native and js bindings)
- makes all known tree managers implement AXHostDelegate

TBR=servolk@chromium.org,jamescook@chromium.org,sky@chromium.org,dmazzoni@chromium.org

Bug: 888152
Test: existing browser_tests (Automation Api tests, ChromeVox tests).
Change-Id: Ia81220ad90c9a0f3177d66a71e6b6e3afc67ce22
Reviewed-on: https://chromium-review.googlesource.com/c/1372482
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615916}
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/chromeos/accessibility/ax_host_service.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/chromeos/accessibility/ax_remote_host_delegate.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/browser/ui/aura/accessibility/automation_manager_aura_browsertest.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/common/extensions/api/automation_internal.idl
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chrome/renderer/resources/extensions/automation_custom_bindings.js
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chromecast/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chromecast/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chromecast/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chromecast/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chromecast/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chromecast/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/chromecast/renderer/extensions/automation_internal_custom_bindings.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_host_delegate.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_host_delegate.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_node_position_unittest.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_position.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_tree_id.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_tree_id.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_tree_id_registry.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/ax_tree_id_registry.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/mojom/ax_tree_id.mojom
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/mojom/ax_tree_id_mojom_traits.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/mojom/ax_tree_id_mojom_traits.h
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/accessibility/mojom/ax_tree_id_mojom_traits_unittest.cc
[modify] https://crrev.com/efd9d9c7471e49e7e479310f04f53d462efedce9/ui/views/controls/webview/webview.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1

commit 1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1
Author: David Tseng <dtseng@chromium.org>
Date: Wed Dec 12 21:56:05 2018

Remove fake alert AXObjWrapper object

Rather than including a fake alert object within the client accessibility tree, make the views tree include it with an explicit aura::Window.

TBR=servolk@chromium.org

Bug: 888152
Change-Id: I9e190a8e437a78c7e27ebfaab70ec20980dff32d
Reviewed-on: https://chromium-review.googlesource.com/c/1368828
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616064}
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/chromecast/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/chromecast/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/aura/window.cc
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/views/BUILD.gn
[add] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/views/accessibility/accessibility_alert_window.cc
[add] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/views/accessibility/accessibility_alert_window.h
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/views/accessibility/ax_root_obj_wrapper.cc
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/views/accessibility/ax_root_obj_wrapper.h
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1/ui/views/accessibility/ax_window_obj_wrapper.h
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58

commit 4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Dec 13 11:54:50 2018

Revert "Remove fake alert AXObjWrapper object"

This reverts commit 1ed701bc476de4a3d430cfb2a1ecccdb5c7168d1.

Reason for revert: Causing  crbug.com/914647 

Original change's description:
> Remove fake alert AXObjWrapper object
> 
> Rather than including a fake alert object within the client accessibility tree, make the views tree include it with an explicit aura::Window.
> 
> TBR=servolk@chromium.org
> 
> Bug: 888152
> Change-Id: I9e190a8e437a78c7e27ebfaab70ec20980dff32d
> Reviewed-on: https://chromium-review.googlesource.com/c/1368828
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616064}

TBR=jamescook@chromium.org,sky@chromium.org,dtseng@chromium.org

Change-Id: I595218ff0b34290e10ec160d0445bc7d461936bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 888152
Reviewed-on: https://chromium-review.googlesource.com/c/1375128
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616275}
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/chromecast/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/chromecast/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/ui/aura/window.cc
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/ui/views/BUILD.gn
[delete] https://crrev.com/09175790e8f1377c7dd2acdb5d3814b6ba0411bb/ui/views/accessibility/accessibility_alert_window.cc
[delete] https://crrev.com/09175790e8f1377c7dd2acdb5d3814b6ba0411bb/ui/views/accessibility/accessibility_alert_window.h
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/ui/views/accessibility/ax_root_obj_wrapper.cc
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/ui/views/accessibility/ax_root_obj_wrapper.h
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/4c1e02ab16ed6870de2d3d217f2fa49eb7fe6a58/ui/views/accessibility/ax_window_obj_wrapper.h

Comment 10 by jamescook@chromium.org, Dec 13

Labels: -Proj-Mash-SingleProcess
Important, but not blocking SingleProcessMash any more.
►

Sign in to add a comment