New issue
Advanced search Search tips

Issue 888149 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Home launcher animation after swipe the window from shelf

Project Member Reported by minch@chromium.org, Sep 21

Issue description

Chrome Version: 71.0.3558.0

What steps will reproduce the problem?
(1) Swipe from shelf to bring up the home launcher.
(2) Swipe down to close home launcher and bring down the window.
(3) Drag the window from top.

What is the expected result?
Should not see home launcher animation behind.

What happens instead?
Can still see home launcher animation behind.



 
Hi Sammie, is this sth that you can help take a look?
Labels: -Pri-3 M-71 Pri-2
Status: Started (was: Assigned)
Sure, looking.
This happens if all the windows other than the dragged one is minimized, which is the case with swiping, but can also happen in other ways.
Labels: m-72
Bulk moving all M-71 <P-1's to M-72.
Labels: -M-71 -m-71
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/262d214d2cdfb75376f8aa9cee6dc9a9e54abb46

commit 262d214d2cdfb75376f8aa9cee6dc9a9e54abb46
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Oct 16 20:31:20 2018

cros: Do not animate launcher if dragging app from top.

This may happen if all windows other than the app in question are
minimized because overview tells app list to slide in/out if all windows
are minimized (the dragged app is excluded from overview).

Test: manual
Bug:  888149 
Change-Id: Ib883b138939991195c1dc939a1a5b513384a8cfb
Reviewed-on: https://chromium-review.googlesource.com/c/1241562
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600108}
[modify] https://crrev.com/262d214d2cdfb75376f8aa9cee6dc9a9e54abb46/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/262d214d2cdfb75376f8aa9cee6dc9a9e54abb46/ash/wm/overview/window_selector.h
[modify] https://crrev.com/262d214d2cdfb75376f8aa9cee6dc9a9e54abb46/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/262d214d2cdfb75376f8aa9cee6dc9a9e54abb46/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc

Status: Fixed (was: Started)

Sign in to add a comment