New issue
Advanced search Search tips

Issue 888145 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility


Sign in to add a comment

Accessibility node tree support for mash

Project Member Reported by jamescook@chromium.org, Sep 21

Issue description

Tracking bug for making AX node trees work. This is needed for both SingleProcessMash and out-of-process Mash.

High level design from meeting with dtseng:

* Ash is in charge of the desktop tree. It has an AutomationManagerAura or equivalent.
* "Remote apps" use AXRemoteHost to supply node trees to ash
* The browser is just a "remote app" like keyboard shortcut viewer
* Ash passes the node trees to the browser, which forwards them to the accessibility extension
* As a future optimization we might pass around mojo interface pointers so the remote app could talk directly to the browser, or directly to the extension

Things to do to make this happen:
* Either refactor AutomationManagerAura and move it to ash, or write something similar and new
* Kill Profile dependencies where possible
* Remove //ash dependencies from //chrome/browser accessibility code
* Deal with RenderViewHost / WebView embedding
* Support multiple remote hosts with different AX tree ids

See blocked-on bugs.

 
Blockedon: 888147
Blockedon: 888151
Blockedon: 888152
Blockedon: 888750
Blockedon: 891773
Owner: dmazz...@chromium.org
Reassigning to dmazzoni to do the work for splitting each widget into its own tree source. Please assign back to me if you can't get to this in this milestone.
Blocking: 679782
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e66f47c26268064cd51fc416c210dab7fd99286

commit 1e66f47c26268064cd51fc416c210dab7fd99286
Author: James Cook <jamescook@chromium.org>
Date: Tue Nov 27 15:09:49 2018

Simplify AXTreeSourceViews class hierarchy

Push some functionality down from AXTreeSourceAura and AXTreeSourceMus
into AXTreeSourceViews.

This allows AXTreeSourceViews to completely implement the AXTreeSource
interface, eliminating the weird "subclasses must implement GetRoot"
condition.

Just cleanup, no functional changes.

Bug: 888145
Test: views_unittests, views_mus_unittests
Change-Id: I1c1b2cfa856fe6f5e5bcf8dfff172a7ffb6e5339
Reviewed-on: https://chromium-review.googlesource.com/c/1351776
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611112}
[modify] https://crrev.com/1e66f47c26268064cd51fc416c210dab7fd99286/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc
[modify] https://crrev.com/1e66f47c26268064cd51fc416c210dab7fd99286/chrome/browser/ui/aura/accessibility/ax_tree_source_aura.h
[modify] https://crrev.com/1e66f47c26268064cd51fc416c210dab7fd99286/ui/views/accessibility/ax_tree_source_views.cc
[modify] https://crrev.com/1e66f47c26268064cd51fc416c210dab7fd99286/ui/views/accessibility/ax_tree_source_views.h
[modify] https://crrev.com/1e66f47c26268064cd51fc416c210dab7fd99286/ui/views/accessibility/ax_tree_source_views_unittest.cc
[modify] https://crrev.com/1e66f47c26268064cd51fc416c210dab7fd99286/ui/views/mus/ax_tree_source_mus.cc
[modify] https://crrev.com/1e66f47c26268064cd51fc416c210dab7fd99286/ui/views/mus/ax_tree_source_mus.h

Blocking: 889093
Blockedon: 911773
Blockedon: 911774
Blockedon: 911776
Blockedon: 911784
Blockedon: 911945
Labels: -Proj-Mash-SingleProcess
SingleProcessMash is done (see blocked-on bugs). Multi-process work remains.

Sign in to add a comment