New issue
Advanced search Search tips

Issue 888131 link

Starred by 2 users
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Add support for popup windows in WebRunner and Chromium FIDL service

Project Member Reported by kmarshall@chromium.org, Sep 21 
Bug for tracking implementation effort for handling popup windows. For the Runner, this means exposing popups in a way that is idiomatically correct for Fuchsia Mods. For the Chromium service, it means exposing the popups in a way that gives the embedder control over how the child windows are owned and presented.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8583bf4caad163dc92661347d24338692560fe07

commit 8583bf4caad163dc92661347d24338692560fe07
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Sat Sep 22 01:12:54 2018

[fuchsia] Temporarily block popup window creation.

This addresses the current crashing bug that takes place whenever popup windows
are spawned, due to the fact that no WindowParentingClient exists to handle
the newly spawned ui::Window. With this solution, the child windows are
never spawned in the first place.

* Relocated 'content' overrides to FrameImpl's private declarations.
* Misc. IWYU cleanups.

Bug: 888131
Change-Id: I735565047bbe4c8ebab5154a57ad323f33ef8e48
Reviewed-on: https://chromium-review.googlesource.com/1239419
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593402}
[modify] https://crrev.com/8583bf4caad163dc92661347d24338692560fe07/webrunner/browser/frame_impl.cc
[modify] https://crrev.com/8583bf4caad163dc92661347d24338692560fe07/webrunner/browser/frame_impl.h

Comment 2 by kmarshall@chromium.org, Jan 15

Status: Available (was: Assigned)

Comment 3 by kmarshall@chromium.org, Jan 15

Owner: ----
►

Sign in to add a comment