Issue metadata
Sign in to add a comment
|
org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_FocusFakeBox__DisableInterestFeed is flaky |
||||||||||||||||||||||
Issue descriptionorg.chromium.chrome.browser.ntp.NewTabPageTest#testRender_FocusFakeBox__DisableInterestFeed is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyhgELEgVGbGFrZSJ7Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RSZW5kZXJfRm9jdXNGYWtlQm94X19EaXNhYmxlSW50ZXJlc3RGZWVkDA. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_FocusFakeBox__DisableInterestFeed&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyhgELEgVGbGFrZSJ7Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RSZW5kZXJfRm9jdXNGYWtlQm94X19EaXNhYmxlSW50ZXJlc3RGZWVkDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Sep 24
,
Sep 24
org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_FocusFakeBox__DisableInterestFeed is flaky. Findit has detected 3 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyhgELEgVGbGFrZSJ7Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RSZW5kZXJfRm9jdXNGYWtlQm94X19EaXNhYmxlSW50ZXJlc3RGZWVkDA. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_FocusFakeBox__DisableInterestFeed&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyhgELEgVGbGFrZSJ7Y2hyb21pdW1AY2hyb21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RSZW5kZXJfRm9jdXNGYWtlQm94X19EaXNhYmxlSW50ZXJlc3RGZWVkDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Sep 25
Our render tests are unfortunately quite flaky.... best thing to do is just disable for now.
,
Sep 25
,
Sep 26
Removing Sheriff-Chromium because bug is assigned.
,
Sep 26
Sorry misinterpreted these[1] instructions, first time sheriff here, re-adding the label until I take a closer look at the bug. [1] http://dev.chromium.org/developers/tree-sheriffs/sheriffing-bug-queues
,
Sep 26
Becky, could this be a result of your recent CL to enable more tests for the interest feed? Example failure images attached
,
Sep 26
It looks like the failure one is still running animation. I'll disable it first and investigate.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50d6c441a858d7b32ad9ac3898e85b0079f32a88 commit 50d6c441a858d7b32ad9ac3898e85b0079f32a88 Author: Becky Zhou <huayinz@chromium.org> Date: Wed Sep 26 17:10:52 2018 Disable flaky test NewTabPageTest#testRender_FocusFakeBox Bug: 888129 Change-Id: I4000a8b4f25e1a853d882090cdc3a09e8719dd7b Reviewed-on: https://chromium-review.googlesource.com/1246464 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594358} [modify] https://crrev.com/50d6c441a858d7b32ad9ac3898e85b0079f32a88/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
,
Sep 26
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7219843d865a317b5389371bc83d35b80041f796 commit 7219843d865a317b5389371bc83d35b80041f796 Author: Becky Zhou <huayinz@chromium.org> Date: Thu Sep 27 21:50:25 2018 [Feed] Speculative fix for flaky render test on Feed NTP + NewTabPageTest#testRender_FocusFakeBox + NewTabPageTest#testRender_ArticleSectionHeader Bug: 888129, 888997 Change-Id: Ic7d66bf90c1fe0a42c22224a5a889a04e6ffb7d1 Reviewed-on: https://chromium-review.googlesource.com/1249129 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#594880} [modify] https://crrev.com/7219843d865a317b5389371bc83d35b80041f796/chrome/android/java/src/org/chromium/chrome/browser/widget/ScrimView.java [modify] https://crrev.com/7219843d865a317b5389371bc83d35b80041f796/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
,
Nov 16
hauyinz@ looks like this is still flaking a lot on some configurations: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testRender_FocusFakeBox__DisableInterestFeed https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-kitkat-arm-rel/11648 Error from above log: I 650.527s run_tests_on_device(061d5d3c0b2bcc17) detected failure in org.chromium.chrome.browser.ntp.NewTabPageTest#testRender_FocusFakeBox__DisableInterestFeed. raw output: I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: numtests=1 I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: stream= I 650.528s run_tests_on_device(061d5d3c0b2bcc17) org.chromium.chrome.browser.ntp.NewTabPageTest: I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: id=AndroidJUnitRunner I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: test=testRender_FocusFakeBox__DisableInterestFeed I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.ntp.NewTabPageTest I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: current=1 I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS_CODE: 1 I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: numtests=1 I 650.528s run_tests_on_device(061d5d3c0b2bcc17) INSTRUMENTATION_STATUS: stream= I 650.528s run_tests_on_device(061d5d3c0b2bcc17) Error in testRender_FocusFakeBox__DisableInterestFeed(org.chromium.chrome.browser.ntp.NewTabPageTest): I 650.528s run_tests_on_device(061d5d3c0b2bcc17) org.chromium.chrome.test.util.RenderTestRule$RenderTestException: RenderTest Mismatches for: focus_fake_box. See RENDER_TESTS.md for how to fix this failure. I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.chromium.chrome.test.util.RenderTestRule.finished(RenderTestRule.java:254) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.rules.TestWatcher.finishedQuietly(TestWatcher.java:117) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.rules.TestWatcher.access$400(TestWatcher.java:46) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:64) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.rules.RunRules.evaluate(RunRules.java:20) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) I 650.528s run_tests_on_device(061d5d3c0b2bcc17) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.Suite.runChild(Suite.java:128) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.Suite.runChild(Suite.java:27) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.Suite.runChild(Suite.java:128) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.Suite.runChild(Suite.java:27) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) I 650.529s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:127) I 650.530s run_tests_on_device(061d5d3c0b2bcc17) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Nov 16
Hm.. looking at the failure screenshots, it seems like the sign-in promo is still being added the the recycler view. I'll disable it now and then attempt a fix.
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07be96d87488a1fbf6c32a7bab2276c05cef2af9 commit 07be96d87488a1fbf6c32a7bab2276c05cef2af9 Author: Becky Zhou <huayinz@chromium.org> Date: Sat Nov 17 00:30:38 2018 Disable flaky test NewTabPageTest#testRender_FocusFakeBox TBR=twellington@chromium.org Bug: 888129 Change-Id: I184b0e86872093b249b1c7f729be75d55e1c355d Reviewed-on: https://chromium-review.googlesource.com/c/1341023 Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609047} [modify] https://crrev.com/07be96d87488a1fbf6c32a7bab2276c05cef2af9/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 24