New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 888118 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ui: shill: cellular strings need updating

Project Member Reported by akhouderchah@chromium.org, Sep 21

Issue description

The text we want to display to the user on PCO updates has been changed.

The corresponding changes must be made to chrome/app/chromeos_strings.grdp in the chromium repo
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93cf6f918c86a39381c4712120323867e1c92eb9

commit 93cf6f918c86a39381c4712120323867e1c92eb9
Author: Alex Khouderchah <akhouderchah@google.com>
Date: Tue Sep 25 00:08:24 2018

[CrOS] Update strings used on cellular status change

Protocol Configuration Options, or PCOs, are information elements
contained in certain cellular messages. While PCOs can serve many
purposes, a notable use is in informing the user equipment (UE) of
the state of the network it is connected to. Changes such as activating
a network or running out of data, for example, result in a change of
a field within received PCOs.

The text to be displayed to the user on PCO status change no longer
matches the strings in chromeos_strings.grdp. This CL updates those
strings correspondingly.

Bug:  888118 
Change-Id: I0cf94ed4151baec9cc43b84cbf41ecf5bd5a9f7f
Reviewed-on: https://chromium-review.googlesource.com/1238478
Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593761}
[modify] https://crrev.com/93cf6f918c86a39381c4712120323867e1c92eb9/chrome/app/chromeos_strings.grdp

Status: Fixed (was: Started)
Cc: geohsu@chromium.org
Labels: Merge-Request-70
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 9

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 9

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6faacd5962d2b74439457442e847809177c6ca6e

commit 6faacd5962d2b74439457442e847809177c6ca6e
Author: Alex Khouderchah <akhouderchah@google.com>
Date: Tue Oct 09 23:14:55 2018

[CrOS] Update strings used on cellular status change

Protocol Configuration Options, or PCOs, are information elements
contained in certain cellular messages. While PCOs can serve many
purposes, a notable use is in informing the user equipment (UE) of
the state of the network it is connected to. Changes such as activating
a network or running out of data, for example, result in a change of
a field within received PCOs.

The text to be displayed to the user on PCO status change no longer
matches the strings in chromeos_strings.grdp. This CL updates those
strings correspondingly.

Bug:  888118 
Change-Id: I0cf94ed4151baec9cc43b84cbf41ecf5bd5a9f7f
Reviewed-on: https://chromium-review.googlesource.com/1238478
Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593761}(cherry picked from commit 93cf6f918c86a39381c4712120323867e1c92eb9)
Reviewed-on: https://chromium-review.googlesource.com/c/1272436
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#935}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/6faacd5962d2b74439457442e847809177c6ca6e/chrome/app/chromeos_strings.grdp

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6faacd5962d2b74439457442e847809177c6ca6e

Commit: 6faacd5962d2b74439457442e847809177c6ca6e
Author: akhouderchah@google.com
Commiter: govind@chromium.org
Date: 2018-10-09 23:14:55 +0000 UTC

[CrOS] Update strings used on cellular status change

Protocol Configuration Options, or PCOs, are information elements
contained in certain cellular messages. While PCOs can serve many
purposes, a notable use is in informing the user equipment (UE) of
the state of the network it is connected to. Changes such as activating
a network or running out of data, for example, result in a change of
a field within received PCOs.

The text to be displayed to the user on PCO status change no longer
matches the strings in chromeos_strings.grdp. This CL updates those
strings correspondingly.

Bug:  888118 
Change-Id: I0cf94ed4151baec9cc43b84cbf41ecf5bd5a9f7f
Reviewed-on: https://chromium-review.googlesource.com/1238478
Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593761}(cherry picked from commit 93cf6f918c86a39381c4712120323867e1c92eb9)
Reviewed-on: https://chromium-review.googlesource.com/c/1272436
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#935}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Sign in to add a comment