ui: shill: cellular strings need updating |
||||||||
Issue descriptionThe text we want to display to the user on PCO updates has been changed. The corresponding changes must be made to chrome/app/chromeos_strings.grdp in the chromium repo
,
Sep 27
,
Oct 9
,
Oct 9
,
Oct 9
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6faacd5962d2b74439457442e847809177c6ca6e commit 6faacd5962d2b74439457442e847809177c6ca6e Author: Alex Khouderchah <akhouderchah@google.com> Date: Tue Oct 09 23:14:55 2018 [CrOS] Update strings used on cellular status change Protocol Configuration Options, or PCOs, are information elements contained in certain cellular messages. While PCOs can serve many purposes, a notable use is in informing the user equipment (UE) of the state of the network it is connected to. Changes such as activating a network or running out of data, for example, result in a change of a field within received PCOs. The text to be displayed to the user on PCO status change no longer matches the strings in chromeos_strings.grdp. This CL updates those strings correspondingly. Bug: 888118 Change-Id: I0cf94ed4151baec9cc43b84cbf41ecf5bd5a9f7f Reviewed-on: https://chromium-review.googlesource.com/1238478 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593761}(cherry picked from commit 93cf6f918c86a39381c4712120323867e1c92eb9) Reviewed-on: https://chromium-review.googlesource.com/c/1272436 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#935} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/6faacd5962d2b74439457442e847809177c6ca6e/chrome/app/chromeos_strings.grdp
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6faacd5962d2b74439457442e847809177c6ca6e Commit: 6faacd5962d2b74439457442e847809177c6ca6e Author: akhouderchah@google.com Commiter: govind@chromium.org Date: 2018-10-09 23:14:55 +0000 UTC [CrOS] Update strings used on cellular status change Protocol Configuration Options, or PCOs, are information elements contained in certain cellular messages. While PCOs can serve many purposes, a notable use is in informing the user equipment (UE) of the state of the network it is connected to. Changes such as activating a network or running out of data, for example, result in a change of a field within received PCOs. The text to be displayed to the user on PCO status change no longer matches the strings in chromeos_strings.grdp. This CL updates those strings correspondingly. Bug: 888118 Change-Id: I0cf94ed4151baec9cc43b84cbf41ecf5bd5a9f7f Reviewed-on: https://chromium-review.googlesource.com/1238478 Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593761}(cherry picked from commit 93cf6f918c86a39381c4712120323867e1c92eb9) Reviewed-on: https://chromium-review.googlesource.com/c/1272436 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#935} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 25