If this is really affecting all beta users and isn't just some sort of misconfiguration on zmo@'s machine then it's caused by a huge gap in our testing where we aren't running the same tests (including the GPU tests) against the release branches, and also don't have tryservers for the release branches.

Blocking three bugs which cover adding tests in these configurations. I think we should increase their priority.

The same Beta runs fine with GPU acceleration on cblume's macbooks, but that's a different model with a single Intel GPU.

There are more laptops in the cabinet next to my desk to test with, and a drive which can be used to boot them into 10.13.

If I run with a clean user data dir, then I can launch Chrome with GPU acceleration.

Let me reduce this to P2 then.

When I turn on logging, I got the below message:

[19879:775:0921/153131.217608:ERROR:gl_implementation.cc(281)] Failed to load /Applications/Google Chrome.app/Contents/Versions/70.0.3538.22/Google Chrome Framework.framework/Versions/Current/Libraries/libswiftshader_libGLESv2.dylib: dlopen(/Applications/Google Chrome.app/Contents/Versions/70.0.3538.22/Google Chrome Framework.framework/Versions/Current/Libraries/libswiftshader_libGLESv2.dylib, 1): no suitable image found.  Did find:
	/Applications/Google Chrome.app/Contents/Versions/70.0.3538.22/Google Chrome Framework.framework/Versions/Current/Libraries/libswiftshader_libGLESv2.dylib: file system sandbox blocked stat()
[19879:775:0921/153131.217672:VERBOSE1:gpu_init.cc(238)] gl::init::InitializeGLNoExtensionsOneOff failed
[19879:775:0921/153131.245707:ERROR:viz_main_impl.cc(184)] Exiting GPU process due to errors during initialization
[19873:20739:0921/153131.252338:ERROR:browser_gpu_channel_host_factory.cc(137)] Failed to launch GPU process.

FYI, last time I saw this error message, this was the fix:
https://chromium-review.googlesource.com/c/chromium/src/+/1042496

I thought we didn't launch SwiftShader on mac for users yet? It's only for internal testing purpose at this point?

We don't *ship* SwiftShader on MacOS, but the internal logic could still try to use it/fallback to it, which should probably be prevented on MacOS.

There's also this issue, though, were it seems like people want to ship SwiftShader on MacOS:

https://bugs.chromium.org/p/chromium/issues/detail?id=719257

I'm not sure how this should be handled.

I think it's either shipped or not shipped, so the current state is a bug.

If someone is working on shipping it and that will happen quickly, then I agree that's an automatic fix for this bug. If no one commits to ship it, sugoi@, can you take a shot at this bug and prevent Mac from falling back to SwiftShader at the moment?

I can take a look, but honestly, you know this code better than I do. AFAIK, to trigger SwiftShader on the bots, we explicitly use a --use-gl flag (kbr@ could confirm), so I *think* the only thing to do is prevent the fallback mechanism from happening on MacOS.  So the fix is probably just to ifdef out this line on MacOS:
https://cs.chromium.org/chromium/src/ui/gl/init/gl_factory.cc?l=54

Something like:
#if !defined(OS_MACOSX)
      fallback_to_software_gl = true;
#endif

Does that make sense?

Yeah that sounds like a quick solution until we fully ship SwiftShader on MacOSX

Alexis, sounds like you have a start of a fix. Could you take a look or find another victim?

Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!

[bulk edit] - This issue is marked as a stable blocker for M70. We are two weeks away from M70 Stable. Please take a look urgently!

Will fix  crbug.com/719257  instead.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae

commit 55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae
Author: Alexis Hetu <sugoi@google.com>
Date: Thu Oct 04 18:38:34 2018

Ship SwiftShader on MacOS

Bug:  chromium:719257   chromium:888082 
Change-Id: Ie0b06c336c46fd6b801094fab0ce5d2a0446e84e
Reviewed-on: https://chromium-review.googlesource.com/c/1255305
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596776}
[modify] https://crrev.com/55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae/chrome/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0fa9d678dc3e20dbb96144aa1bb4d0976747bd4

commit c0fa9d678dc3e20dbb96144aa1bb4d0976747bd4
Author: Kevin McNee <mcnee@chromium.org>
Date: Thu Oct 04 20:18:00 2018

Revert "Ship SwiftShader on MacOS"

This reverts commit 55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae.

Reason for revert: Suspected cause of build failure https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/37508

Original change's description:
> Ship SwiftShader on MacOS
> 
> Bug:  chromium:719257   chromium:888082 
> Change-Id: Ie0b06c336c46fd6b801094fab0ce5d2a0446e84e
> Reviewed-on: https://chromium-review.googlesource.com/c/1255305
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596776}

TBR=thestig@chromium.org,ccameron@chromium.org,sugoi@chromium.org,kbr@chromium.org,markchang@chromium.org

Change-Id: I5382ffee2bf0636117bcc6366614df44a78d3a72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:719257   chromium:888082 
Reviewed-on: https://chromium-review.googlesource.com/c/1262660
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596824}
[modify] https://crrev.com/c0fa9d678dc3e20dbb96144aa1bb4d0976747bd4/chrome/BUILD.gn

Friendly ping to look into this issue and to provide further update on this issue as it has been marked as a stable blocker.

Stable is moving to M70 very soon.

Thanks!	

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/125c8de8707bdf7badb54ff5ac375e2074893122

commit 125c8de8707bdf7badb54ff5ac375e2074893122
Author: Alexis Hetu <sugoi@google.com>
Date: Thu Oct 11 19:02:24 2018

Ship SwiftShader on MacOS

Also fixed swiftshader symbol generation on MacOS

Bug:  chromium:719257   chromium:888082 
Change-Id: I5e8754c278914c519e71c77ed792f198516a1556
Reviewed-on: https://chromium-review.googlesource.com/c/1276550
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598874}
[modify] https://crrev.com/125c8de8707bdf7badb54ff5ac375e2074893122/chrome/BUILD.gn

@Alexis Hetu: As we are not very sure about the test steps, actual and expected behaviour, could you please help us by providing the required info to test and verify this issue(....if this can be verified manually).

Thanks!

@vamshi.kommuri: Unless your GPU is blacklisted, you won't see the issue. In that case, launch Chrome using --disable-gpu. Pages using WebGL should fail to load before the fix, but should load successfully with SwiftShader after the fix.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.

Comment#22 correction: Accidentally -cc'ed dpranke@chromium.org, correcting it.

Chatted with sugoi@, this is same as M69. Let's target this for M71. 

I just hit this in the released Chrome 70. Am I stuck launching chrome with --disable-gpu until 71 comes out?