tryjob results: add support for "edit" patchset |
||||||||||||||||||||||
Issue descriptionOn https://chromium-review.googlesource.com/c/chromium/src/+/1234333 the CQ status seems frozen and does not reflect the trybot activity. jbudorick@ can see the correct status on the same page.
,
Oct 4
I'm probably not the best person to look at it. over to the DevX trooper queue for triage.
,
Oct 4
,
Oct 4
Hi Andrii, could you help on this issue? Or who should be the right person to handle this?
,
Oct 4
So, if CQ status seems frozen, it's not Gerrit, but CQ status which doesn't reflect Gerrit. But, can you elaborate what exactly is stale in CQ status? And which patchset was this? Note that CQ status may easily be 1-2 minutes behind.
,
Oct 4
> And which patchset was this? This is about which patchset does gerrit display -- your screenshot sadly doesn't include that info. If I were to guess, https://chromium-review.googlesource.com/c/chromium/src/+/1234333/11 looks like what I see in schreenshot. In this case, you were basically looking at stale patchset.
,
Oct 5
Sotty it was not clear. Everything on the screenshot is on PS 18 (hence the issue). Not that the CL is now only showing the status of PS 19, even if I change the PS displayed. I also still have the "Choose trybots" button, even if the CL is submitted (I don't know if it is an issue, but I don't have it on other submitted CL).
,
Oct 5
Wrt to Gerrit tryjobs display, +Nodir@ > Not that the CL is now only showing the status of PS 19, even if I change the PS displayed. That's weird. In my case, the displayed tryjobs do change, though with delay. This may be a bug in itself. > I also still have the "Choose trybots" button Hm, that's possibly deserving its own tracking bug in Infra>Codereview>Gerrit>BUildbucket. Btw, I also see on screenshots that you have a butler (or whatever its name) chrome extension installed which adds overlay of owners and other stuff. Maybe it interferes from Gerrit plugin for displaying tryjobs?
,
Oct 5
PS 18 is the same for me, no bots For me, this is not really an issue. The CL is submitted and I don't have the problem on my other CL. So I am fine to won't fix it if you think it is only a one time issue.
,
Oct 5
I doubt this is a one time issue, but I don't know if is just you and more widespread. If you don't mind providing more info, share browser console log, perhaps there are some errors there? Also, it may be helpful to see network requests made, particularly if any failed or took too long time.
,
Oct 5
olivierrobin's screenshots say "Showing jobs from patch set **edit**", emphasis mine. tandrii's screenshots say "Showing jobs from patch set 18". olivierrobin, is your CL in editing mode? looks like the plugin needs to be updated to skip "edit" patchset
,
Oct 5
,
Oct 5
,
Oct 5
I don't think I am in edit mode. At least I don't have the open/publish buttons at the top. Note that on the initial issue, I was stuck at PS11, which is not an edit PS. I did all these edits, whitespace changes trying to unblock the trybots (I did not know they were working). Also, this CL was initially based on another CL (I think it was a chain of 4) and I had some trouble rebasing them (my fault, not because of bugs) but I may have generated an unexpected state. I screenshot the errors in console (There are a lot of info line that I don't think are interesting, (attached text file). The only failing network connection is avatar?s=32 There does not seem to be query taking to much time. There are ongoing search? and current? queries that continue to be triggered.
,
Oct 5
please add a breakpoint in _computeValidPatchNums of https://chromium-review.googlesource.com/plugins/buildbucket/static/cr-buildbucket-view.js normally, the returned patchNums is an array of numbers, but your case it contains a string. This is unusual. Please paste value of change.revisions
,
Oct 5
Screenshot attached. Full JSON https://paste.googleplex.com/6585621720072192
,
Oct 5
patchNums at the end is ["edit"]
,
Oct 5
Result of the debug in https://chromium-review.googlesource.com/plugins/buildbucket/static/cr-buildbucket-view.js The first revision does not have a number, so it is not filtered out by line 244 (_number is "edit") As kind is not a trivial one, it breaks on line 252. So only the trybots for path edit are displayed (and there are non of them).
,
Oct 5
it would also be interesting to know why this works differently for tandrii@ who can see trybots at patch 18
,
Oct 5
i don't see "edit" revision. I think only the author can see it. https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1265341
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/0a82aa4616bdf852422c18ef8dd5a2b77ac9c396 commit 0a82aa4616bdf852422c18ef8dd5a2b77ac9c396 Author: Nodir Turakulov <nodir@google.com> Date: Fri Oct 05 21:56:30 2018 Add support for edit mode A revision in edit mode has _number == "edit". Skip such revisions. Bug: 888057 Change-Id: I4bbce9886bfd5f26b9723b88510d7a301469783f Reviewed-on: https://chromium-review.googlesource.com/c/1265341 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/0a82aa4616bdf852422c18ef8dd5a2b77ac9c396/test/cr-buildbucket-view_test.html [modify] https://crrev.com/0a82aa4616bdf852422c18ef8dd5a2b77ac9c396/src/main/resources/static/cr-buildbucket-view.js
,
Oct 8
the fix was deployed to canary instance. Please ensure that the bug is fixed in https://canary-chromium-review.googlesource.com/c/chromium/src/+/1234333 (note different host name)
,
Oct 8
Yes, it works Thanks
,
Oct 18
olivierrobin, this will deployed some time ago, please verify that this is indeed fixed
,
Oct 19
As mentionned in #25, it works now (I did not have the issue again). |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, Oct 4Status: Assigned (was: Untriaged)