New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 888049 link

Starred by 32 users
Status: Verified
Owner:
jdufault@chromium.org
Closed: Oct 23
Cc:
zalcorn@chromium.org
sdantul...@chromium.org
mkarkada@chromium.org
dhadd...@chromium.org
█ rtillilie@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Missing ChromeOS/Chrome version at start screen

Project Member Reported by abod...@chromium.org, Sep 21 
Chrome OS 11021.23.0, 70.0.3538.28 Beta

What steps will reproduce the problem?
(1)Press ALT +V at sign-in or login screen(make sure build should be Beta/Stable)
(2)
(3)

What is the expected result?
Should see ChromeOS/Chrome version at start screen for Beta/Stable builds.

What happens instead?
Missing ChromeOS/Chrome version at start screen


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by abod...@chromium.org, Sep 21

Labels: OS-Chrome

Comment 2 by weifangsun@chromium.org, Sep 21

Components: -UI>Shell

Comment 3 by trumbull@chromium.org, Sep 25 

Is this a dup of  https://crbug.com/848108 ?

We have two feedback reports from users on M70 Beta about this issue:
- https://listnr.corp.google.com/report/85682266140
- https://listnr.corp.google.com/report/85674249754

Comment 4 by trumbull@chromium.org, Sep 26

Labels: -Pri-2 Pri-1
Owner: jdufault@chromium.org
Per Albert, updating to P1

Comment 5 by trumbull@chromium.org, Sep 26

Cc: rtillilie@chromium.org
This may be especially important to Enterprise Admins.

Comment 6 by jdufault@chromium.org, Sep 27

Status: Started (was: Untriaged)
We do show version information, but I was not aware of the Alt+V shortcut to force it to display.

Comment 7 by jdufault@chromium.org, Sep 28

Cc: jdufault@chromium.org zalcorn@chromium.org
 Issue 888999  has been merged into this issue.

Comment 9 by geo...@google.com, Oct 1 

Friendly ping, please provide an update on this issue. Is this still RBS (if not please remove the label)? When is the ETA on the work that needs to be done to resolve this? Thanks.

Comment 10 by jdufault@chromium.org, Oct 1 

Yes, this is still RBS. The work should land soon, then needs merge into m70.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fc3139b0089c89128147b6df69c6ef518f45cc8

commit 5fc3139b0089c89128147b6df69c6ef518f45cc8
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Oct 03 22:15:02 2018

cros: Add alt-v accelerator to show system info on views-login.

This works on webui, so port it over to views as well.

Also generally rename version info -> system info to better capture what this
data represents.

Bug:  888049 
Change-Id: Icb35156aafc9b0898dcd57e4c50dd09b067585b6
Reviewed-on: https://chromium-review.googlesource.com/c/1249823
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596395}
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/login_screen_controller.cc
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/login_screen_controller.h
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/chrome/browser/chromeos/login/lock/views_screen_locker.h
[add] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/chrome/browser/chromeos/login/mojo_system_info_dispatcher.cc
[add] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/chrome/browser/chromeos/login/mojo_system_info_dispatcher.h
[delete] https://crrev.com/af86de0fe5c1b37e1a16b6bf3d6b60f03e6fdbde/chrome/browser/chromeos/login/mojo_version_info_dispatcher.cc
[delete] https://crrev.com/af86de0fe5c1b37e1a16b6bf3d6b60f03e6fdbde/chrome/browser/chromeos/login/mojo_version_info_dispatcher.h
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/5fc3139b0089c89128147b6df69c6ef518f45cc8/chrome/browser/chromeos/login/ui/login_display_host_mojo.h

Comment 12 by jdufault@chromium.org, Oct 3

Labels: Merge-Request-70
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 3

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by geo...@google.com, Oct 4

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 4

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff640516d51aec3cca867f92569e8a7f6d481488

commit ff640516d51aec3cca867f92569e8a7f6d481488
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Oct 04 16:29:13 2018

cros: Add alt-v accelerator to show system info on views-login.

This works on webui, so port it over to views as well.

Also generally rename version info -> system info to better capture what this
data represents.

TBR=jdufault@google.com

(cherry picked from commit 5fc3139b0089c89128147b6df69c6ef518f45cc8)

Bug:  888049 
Change-Id: Icb35156aafc9b0898dcd57e4c50dd09b067585b6
Reviewed-on: https://chromium-review.googlesource.com/c/1249823
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#596395}
Reviewed-on: https://chromium-review.googlesource.com/c/1261924
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#853}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/login_screen_controller.cc
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/login_screen_controller.h
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/chrome/browser/chromeos/login/lock/views_screen_locker.h
[add] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/chrome/browser/chromeos/login/mojo_system_info_dispatcher.cc
[add] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/chrome/browser/chromeos/login/mojo_system_info_dispatcher.h
[delete] https://crrev.com/7a6a5beb122c024725e82fe6c32ba946bfea9a25/chrome/browser/chromeos/login/mojo_version_info_dispatcher.cc
[delete] https://crrev.com/7a6a5beb122c024725e82fe6c32ba946bfea9a25/chrome/browser/chromeos/login/mojo_version_info_dispatcher.h
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/ff640516d51aec3cca867f92569e8a7f6d481488/chrome/browser/chromeos/login/ui/login_display_host_mojo.h

Comment 16 by jdufault@chromium.org, Oct 4

Status: Fixed (was: Started)
Project Member

Comment 17 by cr-audit...@appspot.gserviceaccount.com, Oct 4

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ff640516d51aec3cca867f92569e8a7f6d481488

Commit: ff640516d51aec3cca867f92569e8a7f6d481488
Author: jdufault@google.com
Commiter: jdufault@chromium.org
Date: 2018-10-04 16:29:13 +0000 UTC

cros: Add alt-v accelerator to show system info on views-login.

This works on webui, so port it over to views as well.

Also generally rename version info -> system info to better capture what this
data represents.

TBR=jdufault@google.com

(cherry picked from commit 5fc3139b0089c89128147b6df69c6ef518f45cc8)

Bug:  888049 
Change-Id: Icb35156aafc9b0898dcd57e4c50dd09b067585b6
Reviewed-on: https://chromium-review.googlesource.com/c/1249823
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#596395}
Reviewed-on: https://chromium-review.googlesource.com/c/1261924
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#853}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Comment 18 by rick.hum...@wolfcreek.ab.ca, Oct 9 

Just updated to latest version 70.0.3538.41 and still not fixed

Comment 19 by jdufault@chromium.org, Oct 9 

The fix is first available in build 70.0.3538.48, which hasn't been released yet.

Comment 20 by geo...@google.com, Oct 11 

 Issue 894442  has been merged into this issue.

Comment 21 by jayhlee@google.com, Oct 11

Status: Verified (was: Fixed)
confirmed working now on 11021.45.0 which should hit beta channel soon.

Comment 22 by jayhlee@google.com, Oct 23

Labels: -ReleaseBlock-Stable
Status: Assigned (was: Verified)
Re-opening as it seems now alt+v a 2nd time no longer removes the version info.

Can we clarify if not being able to remove is expected behavior? Ideally we'd allow removal with a 2nd alt+v which was old behavior.

Removing RBS as this shouldn't block m70 stable initial release though ideally we'll get it in a refresh.

Comment 23 by jdufault@chromium.org, Oct 23

Status: Verified (was: Assigned)
I'm not convinced there is a use case for removing the info with a second alt-v, and it added significant technical complexity to support, so I dropped support.

Comment 24 by zalcorn@chromium.org, Jan 4 

 Issue 897188  has been merged into this issue.
►

Sign in to add a comment