New issue
Advanced search Search tips

Issue 888035 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 4
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 778843



Sign in to add a comment

Assertion in content/test/gpu/gpu_tests/color_profile_manager_mac.py

Project Member Reported by erikc...@chromium.org, Sep 21

Issue description

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934814080768808336/+/steps/pixel_test_on_Intel_GPU_on_Mac__with_patch__on_Mac-10.12.6/0/stdout

"""
Traceback (most recent call last):
  <module> at /b/s/w/ir/third_party/catapult/telemetry/telemetry/testing/run_browser_tests.py:359
    ret_code = RunTests(sys.argv[1:])
  RunTests at /b/s/w/ir/third_party/catapult/telemetry/telemetry/testing/run_browser_tests.py:328
    ret, _, _ = runner.run()
  run at /b/s/w/ir/third_party/catapult/third_party/typ/typ/runner.py:179
    ret, full_results = self._run_tests(result_set, test_set)
  _run_tests at /b/s/w/ir/third_party/catapult/third_party/typ/typ/runner.py:466
    self._run_one_set(self.stats, result_set, test_set)
  _run_one_set at /b/s/w/ir/third_party/catapult/third_party/typ/typ/runner.py:511
    test_set.isolated_tests, 1)
  _run_list at /b/s/w/ir/third_party/catapult/third_party/typ/typ/runner.py:537
    _setup_process, _teardown_process)
  make_pool at /b/s/w/ir/third_party/catapult/third_party/typ/typ/pool.py:28
    return _AsyncPool(host, jobs, callback, context, pre_fn, post_fn)
  __init__ at /b/s/w/ir/third_party/catapult/third_party/typ/typ/pool.py:188
    self.context_after_pre = pre_fn(self.host, 1, self.context)
  _setup_process at /b/s/w/ir/third_party/catapult/third_party/typ/typ/runner.py:807
    child.context_after_setup = child.setup_fn(child, child.context)
  _SetUpProcess at /b/s/w/ir/third_party/catapult/telemetry/telemetry/testing/run_browser_tests.py:349
    context.test_class.SetUpProcess()
  SetUpProcess at /b/s/w/ir/content/test/gpu/gpu_tests/pixel_integration_test.py:67
    options.dont_restore_color_profile_after_test)
  ForceUntilExitSRGB at /b/s/w/ir/content/test/gpu/gpu_tests/color_profile_manager.py:22
    color_profile_manager_mac.GetDisplaysToProfileURLMap()
  GetDisplaysToProfileURLMap at /b/s/w/ir/content/test/gpu/gpu_tests/color_profile_manager_mac.py:83
    device_id = device_info['DeviceID']
TypeError: 'NoneType' object has no attribute '__getitem__'
"""

Not sure what the root cause of this problem is, but at the very least the test code should gracefully handle a None result.
 
Blocking: 778843
Labels: -Pri-3 Pri-2
Something's wrong with this machine's KVM adapter connection and it's causing tests to fail.  Issue 778843  has been filed for a while about it, and this machine should have been removed from the Swarming pool. I just did this again in the other bug. A clearer error message will be helpful.

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dceee4aef7347203352d8c8125ec4061718ca8b9

commit dceee4aef7347203352d8c8125ec4061718ca8b9
Author: erikchen <erikchen@chromium.org>
Date: Mon Sep 24 17:59:55 2018

Handle nil return from ColorSyncDeviceCopyDeviceInfo.

ColorSyncDeviceCopyDeviceInfo sometimes returns nil. The GPU test framework
should gracefully handle this failure.

Bug:  888035 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6374f2ef01e6272a7220a030e1e0ff5ecdaa80b9
Reviewed-on: https://chromium-review.googlesource.com/1238780
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593596}
[modify] https://crrev.com/dceee4aef7347203352d8c8125ec4061718ca8b9/content/test/gpu/gpu_tests/color_profile_manager_mac.py

Labels: Infra-Platform-Test
Status: Fixed (was: Untriaged)

Sign in to add a comment