Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of liberato@chromium.org external/wpt/html/browsers/browsing-the-web/unloading-documents/beforeunload-canceling.html and 19 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty ASAN Builders failed on: - WebKit Linux Trusty ASAN: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN Culprit CL https://crrev.com/254369a5f6df06c2c6be067d14c2cb2a036ba173 suspected by FindIt.
timothygu@: PTAL, and revert / fix / re-assign as needed. thanks!
Problematic CL reverted by https://chromium-review.googlesource.com/c/chromium/src/+/1239216. Still needs some additional investigation on how to fix this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395 commit 17f4e7d2ec13d6112dfcd8aa253f340bdb00d395 Author: Timothy Gu <timothygu@chromium.org> Date: Tue Oct 23 02:29:14 2018 Reland "bindings: Implement timers with V8Function" This is a reland of 254369a5f6df06c2c6be067d14c2cb2a036ba173. It addresses bug 888025 by adding ASAN test expectations, as the relevant V8 feature does not yet support running on ASAN builds. Original change's description: > bindings: Implement timers with V8Function > > This fixes bug 866610 by using the IDL infrastructure to properly enter > the v8::Context before calling the registered callback. > > Also ensure eager finalization of ScheduledAction in DOMTimer to > prevent a memory leak. Added two more effective DCHECKs to confirm. > > Bug: 866610 > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > Reviewed-on: https://chromium-review.googlesource.com/1220486 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593108} TBR=japhet@chromium.org Bug: 866610 , 888025 Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a Reviewed-on: https://chromium-review.googlesource.com/c/1239624 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601830} [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/WebKit/LayoutTests/ASANExpectations [add] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/url-entry-document-timer-frame.html [add] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url-entry-document.window.js [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/bindings/core/v8/scheduled_action.h [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/core/frame/dom_timer.cc [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/core/frame/dom_timer.h [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/core/frame/dom_timer_coordinator.h [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/core/frame/dom_window_timers.cc [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/core/frame/dom_window_timers.h [modify] https://crrev.com/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395/third_party/blink/renderer/core/frame/window_timers.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/892067a4c2be953f9f6cac55e7b8f983c2203a92 commit 892067a4c2be953f9f6cac55e7b8f983c2203a92 Author: Timothy Gu <timothygu@chromium.org> Date: Tue Oct 23 06:46:54 2018 Revert "Reland "bindings: Implement timers with V8Function"" This reverts commit 17f4e7d2ec13d6112dfcd8aa253f340bdb00d395. Reason for revert: Still breaks ASAN Original change's description: > Reland "bindings: Implement timers with V8Function" > > This is a reland of 254369a5f6df06c2c6be067d14c2cb2a036ba173. It addresses bug > 888025 by adding ASAN test expectations, as the relevant V8 feature does not > yet support running on ASAN builds. > > Original change's description: > > bindings: Implement timers with V8Function > > > > This fixes bug 866610 by using the IDL infrastructure to properly enter > > the v8::Context before calling the registered callback. > > > > Also ensure eager finalization of ScheduledAction in DOMTimer to > > prevent a memory leak. Added two more effective DCHECKs to confirm. > > > > Bug: 866610 > > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > > Reviewed-on: https://chromium-review.googlesource.com/1220486 > > Reviewed-by: Nate Chapin <japhet@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Timothy Gu <timothygu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593108} > > TBR=japhet@chromium.org > > Bug: 866610 , 888025 > Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a > Reviewed-on: https://chromium-review.googlesource.com/c/1239624 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601830} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org Change-Id: Ie4f45dfcc1adcc2ac3469eab99dba813723288f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866610 , 888025 Reviewed-on: https://chromium-review.googlesource.com/c/1296057 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#601864} [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/WebKit/LayoutTests/ASANExpectations [delete] https://crrev.com/26111c2602fc3e1a85d1364d1140f99594d54fce/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/url-entry-document-timer-frame.html [delete] https://crrev.com/26111c2602fc3e1a85d1364d1140f99594d54fce/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url-entry-document.window.js [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/bindings/core/v8/scheduled_action.cc [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/bindings/core/v8/scheduled_action.h [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/core/frame/dom_timer.cc [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/core/frame/dom_timer.h [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/core/frame/dom_timer_coordinator.h [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/core/frame/dom_window_timers.cc [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/core/frame/dom_window_timers.h [modify] https://crrev.com/892067a4c2be953f9f6cac55e7b8f983c2203a92/third_party/blink/renderer/core/frame/window_timers.idl
Comment 1 by liber...@chromium.org
, Sep 21Status: Assigned (was: Available)