New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 888022 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 838380



Sign in to add a comment

Merge five recent libaom bug fixes to Branch 3538 for M70

Project Member Reported by wtc@google.com, Sep 21

Issue description

I'd like to request an update to libaom on Branch 3538 for M70,
to merge the following five recent libaom bug fixes:

Bug:  oss-fuzz:10151 
Bug:  oss-fuzz:10242 
Bug:  aomedia:2163 
BUG: b/114621710
BUG: b/114647746
BUG:  oss-fuzz:10252  (a duplicate of b/114647746)

This libaom snapshot passed libaom's nightly tests (including
valgrind and sanitizers) and has been in the Chromium HEAD
since this Wednesday, Sep 19, 2018:

https://chromium.googlesource.com/chromium/src/+/7184de671cca6fae230dc6baa3815e3349d35d89
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 21

Labels: -Merge-Request-70 Hotlist-Merge-Reject Merge-Reject-70
The bug is marked as P3 or Feature. It should not be merged as M70 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Internals>Media>Codecs
Labels: -Pri-3 -Hotlist-Merge-Reject -Merge-Reject-70 Merge-Request-70 Pri-1
Here is my proposed CL for Branch 3538 (M70):
https://chromium-review.googlesource.com/c/chromium/src/+/1239154
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 21

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
Labels: Merge-Request-70
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 21

Labels: -Merge-Request-70
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please be advised that this is a roll request for libaom. There are currently 46 commits in the roll. Not all of them are required to fix the bugs listed above.
Please mark which OS's this is impacting. 
Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Done. This affects all operating systems.
Labels: -OS-Android -OS-iOS
libaom is not built for Android or iOS
It's also not built for arm-based chromebooks but it is built for x86[_64] ones
https://chromium.googlesource.com/chromium/src/+/master/third_party/libaom/options.gni
let's verify this in canary first. 
How does it look in canary?
Hi Abdul:

Frank took a look at go/crash reports and reported that numbers are super low:

https://crash.corp.google.com/browse?q=STRPOS%28product_name%2C+%27Chrome%27%29+%3E+0+AND+STRPOS%28expanded_custom_data.ChromeCrashProto.magic_signature_1.file_path%2C+%27third_party%2Flibaom%27%29+%3E+0

Note that a high number is unlikely given the lack of AV1 content on the Web.
Blocking: 838380
Note, the existing crashes in m71 are:
- an unrelated gpu decoder
- known OOM exceptions
- illegal instruction on amd

We are still good to merge the fixes 
Labels: -Merge-Review-70 Merge-Approved-70
Thanks for more context. Approving merge to M70. branch:3538
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 25

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9943a644150b92c1f9d1360159c4aaa362f0b455

commit 9943a644150b92c1f9d1360159c4aaa362f0b455
Author: Wan-Teh Chang <wtc@google.com>
Date: Tue Sep 25 17:44:19 2018

Roll src/third_party/libaom/source/libaom/ 67645b8f5..f866f5ebb (46 commits)

https://aomedia.googlesource.com/aom.git/+log/67645b8f529c..f866f5ebb34b

$ git log 67645b8f5..f866f5ebb --date=short --no-merges --format='%ad %ae %s'
2018-09-18 wtc Fix cmake -DENABLE_EXAMPLES=0 error.
2018-08-06 chengchen Bitmask patch 7: Optimize traversal steps.
2018-08-03 chengchen Bitmask patch 6: Minor improvement.
2018-07-30 chengchen Bitmask patch 5: Store vertical border and skip using bitmask
2018-09-18 grant.hsu Extend blk_skip to support chroma planes
2018-07-30 chengchen Bitmask patch 4: Store transform size info for vartx
2018-07-26 chengchen Bitmask patch 3: Add more lookup table entries for bitmask.
2018-09-13 anorkin Fix sending repeated random_seed in film grain
2018-09-12 tdaede Only build stats library if examples are enabled.
2018-09-17 wtc Call decoder_decode() even on invalid input data.
2018-09-12 david.barker Fix range check in half_btf() function
2018-09-17 wtc Optimize set_planes_to_neutral_grey for highbd.
2018-07-16 chengchen Bitmask patch 2: Applying filtering once bitmask is built
2018-07-20 chengchen Bitmask patch 1: Reduce u/v horizontal/vertical
2018-09-17 tomfinegan Propagate user private data when film grain enabled.
2018-09-07 umang.saini Fix 32bit build for arm target arch 8
2018-09-13 yaowu Add cmdline switch --skip-film-grain to aomdec
2018-09-17 remya.prakasan Add sse4_1 variant for highbd inv_txfm 32x32
2018-09-17 satish.suman Optimize highbd 64x64 fwd_txfm
2018-08-27 alexanderbokov Add ML-based rectangular partition pruning
(...)

Created with:
  roll-dep src/third_party/libaom/source/libaom
R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@google.com

Bug:  chromium:888022 
Bug:  oss-fuzz:10151 
Bug:  oss-fuzz:10242 
Bug:  aomedia:2163 
BUG: b/114621710
BUG: b/114647746
BUG:  oss-fuzz:10252 
Change-Id: I0bd468082e1dafc5b05820c82d4efd730fc99ffd
Reviewed-on: https://chromium-review.googlesource.com/1239154
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/branch-heads/3538@{#654}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/DEPS
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/README.chromium
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/config/aom_version.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm-neon/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm-neon/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm64/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/arm64/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/generic/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/generic/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/ia32/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/ia32/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/ia32/config/av1_rtcd.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/x64/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/x64/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/linux/x64/config/av1_rtcd.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/win/ia32/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/win/ia32/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/win/ia32/config/av1_rtcd.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/win/x64/config/aom_config.asm
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/win/x64/config/aom_config.h
[modify] https://crrev.com/9943a644150b92c1f9d1360159c4aaa362f0b455/third_party/libaom/source/config/win/x64/config/av1_rtcd.h

Status: Fixed (was: Started)

Sign in to add a comment