New issue
Advanced search Search tips

Issue 888021 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Nov 27
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Pending entry is not created during the session restoration

Project Member Reported by eugene...@chromium.org, Sep 21 
During the session restoration WebState loads last committed URL.

Actual result:
During this load GetPendingItem returns nil. 

Expected result:
Pending Navigation Item should be the same as Last Committed Navigation Item, so GetPendingItem returns correct value.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a988769b409b3345db117b8be5152927639f555e

commit a988769b409b3345db117b8be5152927639f555e
Author: Eugene But <eugenebut@chromium.org>
Date: Wed Oct 03 21:07:11 2018

Mark last committed item as pending during state restoration.

Error presentation code does not work if navigation is failed
without a pending item. It is easier and more correct to actually
create navigation item for state restoration than workaround the
bug in error presentation code.

This fixes the bug when placeholder URL is displayed in the omnibox.

Bug: 887385,  888021 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I94a124d3477d074fcea2d94128f5bbffe4091f2f
Reviewed-on: https://chromium-review.googlesource.com/c/1258611
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596361}
[modify] https://crrev.com/a988769b409b3345db117b8be5152927639f555e/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/a988769b409b3345db117b8be5152927639f555e/ios/web/web_state/web_state_observer_inttest.mm
[modify] https://crrev.com/a988769b409b3345db117b8be5152927639f555e/ios/web/web_state/web_state_unittest.mm

Comment 2 by eugene...@chromium.org, Oct 3 

Fixed for legacy navigation manager. Still needs to be fixed for slim navigation manager.

Comment 3 by eugene...@chromium.org, Nov 22

Owner: eugene...@chromium.org
Status: Started (was: Available)

Comment 4 by eugene...@chromium.org, Nov 27

Status: Fixed (was: Started)
►

Sign in to add a comment