Tests using HTTPS embedded test server fail when running network service OOP on Android |
||||
Issue descriptionAll the tests using EmbeddedTestServer.createAndStartHTTPSServer fail with NS enabled OOP for some reason. These same tests pass when using NetworkServiceInProcess. This could be a test only issue or something bigger with HTTPS.
,
Oct 2
https://cs.chromium.org/chromium/src/content/public/test/network_service_test_helper.cc?rcl=542d7fd59b14726593c015369ef35a7663a934d5&l=207 is the approach that content_browsertests uses
,
Oct 2
Thanks for the pointer!
,
Oct 29
This is test-only, so not canary blocking.
,
Oct 30
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09928a3d8a901d72298ded4f8206c325bcbbf637 commit 09928a3d8a901d72298ded4f8206c325bcbbf637 Author: Clark DuVall <cduvall@chromium.org> Date: Wed Oct 31 01:43:04 2018 Fix HTTPS embedded test server with network service on Android When running tests with network service enabled, we need to initialize NetworkServiceTestHelper to register test certs and perform other setup in the network process. This does the necessary setup for Android, similar to what is alredy being done for desktop here: https://cs.chromium.org/chromium/src/chrome/test/base/chrome_test_launcher.cc?l=167&rcl=024b72104d153da4c609c19d09facb8bd48632b6 Bug: 888020 Change-Id: I7016c42ff59169eb4f32b8531a83266b120a65fe Reviewed-on: https://chromium-review.googlesource.com/c/1306665 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#604106} [modify] https://crrev.com/09928a3d8a901d72298ded4f8206c325bcbbf637/chrome/android/BUILD.gn [modify] https://crrev.com/09928a3d8a901d72298ded4f8206c325bcbbf637/chrome/browser/android/DEPS [modify] https://crrev.com/09928a3d8a901d72298ded4f8206c325bcbbf637/chrome/browser/android/chrome_entry_point_for_test.cc [modify] https://crrev.com/09928a3d8a901d72298ded4f8206c325bcbbf637/testing/buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter
,
Oct 31
|
||||
►
Sign in to add a comment |
||||
Comment 1 by eroman@chromium.org
, Oct 1Owner: eroman@chromium.org
Status: Assigned (was: Available)