New issue
Advanced search Search tips

Issue 888011 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

NavigationItemImpl transition type is not restored

Project Member Reported by eugene...@chromium.org, Sep 21

Issue description

NavigationItemStorageBuilder::BuildNavigationItemImpl does not restore NavigationItemImpl::transition_type_
 
Kurt, do you think this is WAI, or we actually forgot to implement transition type restoration?
Here's a comment from the old CRWSessionEntry |-initWithCoder:|

// Use a transition type of reload so that we don't incorrectly increase     
// the typed count.  This is what desktop chrome does.

I'm not sure if that's still what Desktop does, but we are currently just leaving the default value of LINK instead of setting to RELOAD.  
Cc: creis@chromium.org
Charlie, do you know if Desktop restores NavigationEntry's transition type in NavigationControllerImpl::SetSessionStorageNamespace or every restored entry will have reload RELOAD transition type? Thanks!
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Cc: eugene...@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't think we restore transition type on desktop, and it does look like it's RELOAD on a restored entry.  Hope that helps.
Cc: -eugene...@chromium.org
Labels: -Pri-2 Pri-3
Owner: eugene...@chromium.org
Status: Started (was: Available)
Thanks Charlie! Will be fixed in crrev.com/1243573
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42707897579086ba3e36e3f35e5a16e73b16655f

commit 42707897579086ba3e36e3f35e5a16e73b16655f
Author: Eugene But <eugenebut@chromium.org>
Date: Tue Sep 25 21:23:08 2018

Use PAGE_TRANSITION_RELOAD transition type for restored items.

This makes iOS consistent with other platforms that use reload
transition type to avoid incorrect increase for typed count.

Bug:  888011 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7fe963391c00c077bd41bd3235e93396046939ce
Reviewed-on: https://chromium-review.googlesource.com/1243573
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594105}
[modify] https://crrev.com/42707897579086ba3e36e3f35e5a16e73b16655f/ios/web/navigation/navigation_item_storage_builder.mm
[modify] https://crrev.com/42707897579086ba3e36e3f35e5a16e73b16655f/ios/web/web_state/web_state_observer_inttest.mm

Status: Fixed (was: Started)

Sign in to add a comment