New issue
Advanced search Search tips

Issue 887992 link

Starred by 14 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 885012
issue 887867
issue 887884
issue 889437



Sign in to add a comment

Print Preview Refresh: Very large font size issues

Project Member Reported by rbpotter@chromium.org, Sep 21

Issue description

Tracking bug for UI polish issues that only occur with very large/huge font sizes.
 
Blockedon: 887884
Blockedon: 887867
Blockedon: 885012
Blockedon: 889437
Cc: nyerramilli@chromium.org rbasuvula@chromium.org rbpotter@chromium.org
 Issue 889388  has been merged into this issue.
Blockedon: -885012
Blockedon: 885012
 Issue 885012  has been merged into this issue.
 Issue 889437  has been merged into this issue.
Blockedon: -887884
Blockedon: 887884
 Issue 887884  has been merged into this issue.
 Issue 887867  has been merged into this issue.
 Issue 891642  has been merged into this issue.
 Issue 892031  has been merged into this issue.
 Issue 893536  has been merged into this issue.
 Issue 900547  has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ede47e3b1552739bc556b038ebbef082cf5fcce

commit 7ede47e3b1552739bc556b038ebbef082cf5fcce
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Nov 22 07:25:57 2018

Print Preview: Fix error messages for large fonts/languages

Error messages currently appear cut off for large fonts and languages
that cause the messages to wrap onto more than 2 lines.

Size error messages to the full height of the text content and update
styling so that the labels stay aligned with the input when error
messages appear.

Bug:  898802 , 887992
Change-Id: I07036adc127cd9fa95ddede51c44790c867e31ba
Reviewed-on: https://chromium-review.googlesource.com/c/1345544
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610330}
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/7ede47e3b1552739bc556b038ebbef082cf5fcce/chrome/browser/resources/print_preview/new/print_preview_shared_css.html

 Issue 908744  has been merged into this issue.
 Issue 908753  has been merged into this issue.
 Issue 912512  has been merged into this issue.
 Issue 912872  has been merged into this issue.
Cc: viswa.karala@chromium.org
 Issue 919546  has been merged into this issue.

Comment 22 by rbpotter@chromium.org, Jan 16 (6 days ago)

 Issue 922401  has been merged into this issue.

Sign in to add a comment