Change wrong password alert in tablet mode |
||||
Issue descriptionFor users that have more than one keyboard layout enabled in settings, on their second (and third, and fourth...) incorrect password entry, we show the following string: "Sorry, your password still couldn't be verified. Note: if you changed your password recently, your new password will be applied once you sign out, please use the old password here. Hit Control-Shift-Space to switch keyboard layout." When in tablet mode, the keyboard layout is clearly presented on the virtual keyboard itself, so we should remove the last sentence.
,
Sep 24
,
Sep 24
Do we still want to show the message when the device is in tablet mode, but connected to an external keyboard? (AFAIK //ash still considers the device is in tablet mode when connected to a keyboard, so we may need another signal to distinguish this case.)
,
Sep 24
Given that it's just a best-effort warning, I'm okay using the tablet mode signal rather than introducing something more complicated.
,
Sep 24
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd2fe26e75d326cf0de1c698aa3e991d3b647160 commit cd2fe26e75d326cf0de1c698aa3e991d3b647160 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Sep 27 18:16:11 2018 cros: Customize wrong password alert message in tablet mode A small customization: in tablet mode, it doesn't make sense to display a message related to a keyboard shortcut. Bug: 887984 Change-Id: Ife9dbd11a0077b3c8001124b0224d50eac683b9c Reviewed-on: https://chromium-review.googlesource.com/1242079 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594789} [modify] https://crrev.com/cd2fe26e75d326cf0de1c698aa3e991d3b647160/ash/login/ui/lock_contents_view.cc
,
Sep 27
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jdufault@chromium.org
, Sep 24Owner: ----
Status: Available (was: Untriaged)